Skip to content

London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Book Library #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miriamjorna wants to merge 1 commit into from
Closed

London | 26-ITP-Jan | Miriam Jorna | Sprint 2 | Book Library #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 17 additions & 26 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>My Book Library</title>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css">
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
Expand All @@ -31,45 +27,47 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
>
<label for="author">Author:</label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
id="submit-button;"
>
</div>
</div>

<div id="message-container"></div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
Expand All @@ -81,16 +79,9 @@ <h1>Library</h1>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
133 changes: 71 additions & 62 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,23 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
render();
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readCheckbox = document.getElementById("check");
const submitButton = document.getElementById("submit-button");

window.addEventListener("load", function () {
populateStorage();
});
submitButton.addEventListener("click", addBook);
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also include line 12 inside the window "on load" callback?

Copy link
Copy Markdown
Author

@miriamjorna miriamjorna Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no good answer to that. Haste, I think!


function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
if (myLibrary.length === 0) {
const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
Expand All @@ -20,84 +26,87 @@ function populateStorage() {
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
function addBook() {
const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = Number(pagesInput.value);

if (title === "" || author === "" || !Number.isInteger(pages) || pages < 1) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
return;
}
const book = new Book(title, author, pages, readCheckbox.checked);
myLibrary.push(book);
Comment on lines +41 to +43
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

Have you successfully enabled "Format on save" and selected "prettier" as your default JS formatter on VS Code?

Copy link
Copy Markdown
Author

@miriamjorna miriamjorna Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ever since our previous sessions I have religiously double checked if my code was formatted before submitting - except this morning. Apologies!

Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have to if you enabled format on save and select prettier as your default JS formatter.
Not only can these automated tools format the code consistently, they can also save us some time.

titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
readCheckbox.checked = false;
render();
}

function Book(title, author, pages, check) {
function Book(title, author, pages, isRead) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
this.isRead = isRead;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
const table = document.getElementById("display");
const tbody = table.tBodies[0] || table.createTBody();
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
tbody.replaceChildren();
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
for (let i = 0; i < myLibrary.length; i++) {
const row = tbody.insertRow();
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
const changeButton = document.createElement("button");
changeButton.className = "btn btn-success";
changeButton.textContent = myLibrary[i].isRead ? "Yes" : "No";
wasReadCell.appendChild(changeButton);

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
changeButton.addEventListener("click", function () {
myLibrary[i].isRead = !myLibrary[i].isRead;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const delButton = document.createElement("button");
deleteCell.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.textContent = "Delete";
delButton.addEventListener("click", function () {
const deletedBook = myLibrary[i].title;
myLibrary.splice(i, 1);
render();
showMessage(`You've deleted title: ${deletedBook}`);
});
}
function showMessage(message) {
const container = document.getElementById("message-container");
container.innerHTML = "";
const alert = document.createElement("div");
alert.className = "alert alert-warning alert-dismissible fade show";
alert.role = "alert";

alert.innerHTML = `${message} <button type="button" class="close" data-dismiss="alert" aria-label="Close">
<span aria-hidden="true">&times;</span>
</button>`;

container.appendChild(alert);
}
}
Loading