feat(nakama): add BodyTime event flow#15
Merged
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ca363a0 to
c7d00a8
Compare
8ca5b9c to
16f5fbe
Compare
Contributor
Author
|
Local delta review after rebase onto dev:
Verification:
Verdict: APPROVED for merge into dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secondspawn_bodytime_eventto the Nakama runtime for prototype BodyTime earn, spend, and danger-zone drain events.agent_activity, expose body lifecycle in Unity DTOs, and add a Unity gateway wrapper for the Nakama RPC.deadwhen BodyTime reaches zero; further non-idempotent BodyTime mutations are rejected until reincarnation flow exists.Verification
npm run buildinbackend/nakamanpm testinbackend/nakamago test -count=1 ./...inbackend/gatewaygo vet ./...inbackend/gatewaynpx --yes markdownlint-cli2@0.18.1 "*.md" "docs/**/*.md" ".github/**/*.md"git diff --checkLocal Review
Local
code-reviewskill pass result: approved with suggestions. No engine specialist is configured in.Codex/docs/technical-preferences.md, so specialist routing was skipped. The implementation follows ADR 0010 by keeping game-backend profile/economy state in Nakama runtime modules, and follows the Time-as-Currency rule that BodyTime mutations are server-authoritative validated intents.Caveat
Unity clean-worktree batchmode compile is still blocked by the existing Package Manager
pathundefined issue in this repo family, so Editor/MCP compile verification remains required before a no-caveat Unity merge claim.Gemini (@gemini-code-assist) review
Codex (@codex) review