Fix problems from cdeps1.0.94#405
Conversation
|
@ekluzek - I'm going ahead and merging this even though you had marked it as a draft, because it seems good to get these fixes in. If there was more you still wanted to do, that can come in a follow-up PR. |
|
@billsacks I remember running into trouble with testing in this one, which is why I had it marked as a draft. But, I don't remember the details now. I also didn't rimport the datasets, and that should also be done as well. Also pinging @slevis-lmwg. It would be good to have someone else run the aux_cdeps testlist here and make sure the CPLHIST tests either work, or have some sort of problem. And to have someone rimport the datasets. |
|
Shoot, you're right, @ekluzek - the cplhist test is failing now ( The problem is that a dtlimit is exceeded due to too big of a discrepancy between dtmin and dtmax: I'm going to open an issue for this and then temporarily remove this test from the testlist until it's resolved, in order to take the pressure off. |
Description of changes
Fix the problems that @billsacks noticed after cdesp1.0.94 came in. These were both things that I was embarrsesed to have let gone through.
Specific notes
Contributors other than yourself, if any: @billsacks
CDEPS Issues Fixed (include github issue #):
Fixes #402
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers (bfb, different to roundoff, more substantial): b4b
Any User Interface Changes (namelist or namelist defaults changes): No
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
running aux_cdeps
Hashes used for testing:
submodules from: cesm3_0_beta08