Skip to content

fix(bindings): Specific lib name for bindings#187

Merged
BotellaA merged 2 commits into
nextfrom
feat/inspection_lib_start
Jun 29, 2026
Merged

fix(bindings): Specific lib name for bindings#187
BotellaA merged 2 commits into
nextfrom
feat/inspection_lib_start

Conversation

@MelchiorSchuh

Copy link
Copy Markdown
Member

No description provided.

@MelchiorSchuh MelchiorSchuh requested a review from BotellaA June 29, 2026 14:00
@github-actions

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 8 concern(s)
  • bindings/python/src/inspection/brep_inspector.hpp:30:33: error: [clang-diagnostic-error]

    use of undeclared identifier 'pybind11'

       30 |     void define_brep_inspector( pybind11::module& module )
          |                                 ^
  • bindings/python/src/inspection/brep_inspector.hpp:32:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'pybind11'

       32 |         pybind11::class_< BRepInspectionResult >(
          |         ^
  • bindings/python/src/inspection/brep_inspector.hpp:32:27: error: [clang-diagnostic-error]

    'BRepInspectionResult' does not refer to a value

       32 |         pybind11::class_< BRepInspectionResult >(
          |                           ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/include/geode/inspector/inspection/brep_inspector.hpp:38:47: note: declared here
       38 |     struct opengeode_inspector_inspection_api BRepInspectionResult
          |                                               ^
  • bindings/python/src/inspection/brep_inspector.hpp:34:19: error: [clang-diagnostic-error]

    use of undeclared identifier 'pybind11'

       34 |             .def( pybind11::init<>() )
          |                   ^
  • bindings/python/src/inspection/brep_inspector.hpp:34:34: error: [clang-diagnostic-error]

    expected expression

       34 |             .def( pybind11::init<>() )
          |                                  ^
  • bindings/python/src/inspection/brep_inspector.hpp:34:36: error: [clang-diagnostic-error]

    expected expression

       34 |             .def( pybind11::init<>() )
          |                                    ^
  • bindings/python/src/inspection/brep_inspector.hpp:41:9: error: [clang-diagnostic-error]

    use of undeclared identifier 'pybind11'

       41 |         pybind11::class_< BRepInspector, BRepMeshesInspector,
          |         ^
  • bindings/python/src/inspection/brep_inspector.hpp:41:27: error: [clang-diagnostic-error]

    'BRepInspector' does not refer to a value

       41 |         pybind11::class_< BRepInspector, BRepMeshesInspector,
          |                           ^
    /__w/OpenGeode-Inspector/OpenGeode-Inspector/include/geode/inspector/inspection/brep_inspector.hpp:53:46: note: declared here
       53 |     class opengeode_inspector_inspection_api BRepInspector
          |                                              ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit d7e11a3 into next Jun 29, 2026
19 checks passed
@BotellaA BotellaA deleted the feat/inspection_lib_start branch June 29, 2026 18:23
@BotellaA

Copy link
Copy Markdown
Member

🎉 This PR is included in version 6.11.3-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member

🎉 This PR is included in version 6.11.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants