Skip to content

fix(bindings): Specific lib name for bindings #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 2 commits into from
Jun 29, 2026
+2 −1
Merged

fix(bindings): Specific lib name for bindings #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
591f42e
fix(bindings): Specific lib name for bindings
MelchiorSchuh Jun 29, 2026
aa9b7d9
fix missing function
MelchiorSchuh Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ add_geode_python_wheel(
DESCRIPTION
"Open source framework for inspecting the validity of geometric models"
MODULES
"inspection.py"
"inspector_inspection.py"
"validity.py"
LICENSE "MIT"
)
0 bindings/python/inspection.py → bindings/python/inspector_inspection.py
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions bindings/python/src/inspection/brep_inspector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,18 @@

namespace geode
{
void define_brep_inspector( pybind11::module& module )

Check failure on line 30 in bindings/python/src/inspection/brep_inspector.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/inspection/brep_inspector.hpp:30:33 [clang-diagnostic-error] 

use of undeclared identifier 'pybind11'
{
pybind11::class_< BRepInspectionResult >(

Check failure on line 32 in bindings/python/src/inspection/brep_inspector.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/inspection/brep_inspector.hpp:32:27 [clang-diagnostic-error] 

'BRepInspectionResult' does not refer to a value

Check failure on line 32 in bindings/python/src/inspection/brep_inspector.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/inspection/brep_inspector.hpp:32:9 [clang-diagnostic-error] 

use of undeclared identifier 'pybind11'
module, "BRepInspectionResult" )
.def( pybind11::init<>() )

Check failure on line 34 in bindings/python/src/inspection/brep_inspector.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/inspection/brep_inspector.hpp:34:36 [clang-diagnostic-error] 

expected expression

Check failure on line 34 in bindings/python/src/inspection/brep_inspector.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/inspection/brep_inspector.hpp:34:34 [clang-diagnostic-error] 

expected expression

Check failure on line 34 in bindings/python/src/inspection/brep_inspector.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/inspection/brep_inspector.hpp:34:19 [clang-diagnostic-error] 

use of undeclared identifier 'pybind11'
.def_readwrite( "meshes", &BRepInspectionResult::meshes )
.def_readwrite( "topology", &BRepInspectionResult::topology )
.def( "nb_issues", &BRepInspectionResult::nb_issues )
.def( "string", &BRepInspectionResult::string )
.def( "inspection_type", &BRepInspectionResult::inspection_type );

pybind11::class_< BRepInspector, BRepMeshesInspector,

Check failure on line 41 in bindings/python/src/inspection/brep_inspector.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/inspection/brep_inspector.hpp:41:27 [clang-diagnostic-error] 

'BRepInspector' does not refer to a value

Check failure on line 41 in bindings/python/src/inspection/brep_inspector.hpp

View workflow job for this annotation

GitHub Actions / test / tidy

bindings/python/src/inspection/brep_inspector.hpp:41:9 [clang-diagnostic-error] 

use of undeclared identifier 'pybind11'
BRepTopologyInspector >( module, "BRepInspector" )
.def( pybind11::init< const BRep& >() )
.def( "inspect_brep", &BRepInspector::inspect_brep );
Expand Down
Loading