Fix update DMG installation flow#18
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe update menu action now calls a renamed method that downloads and opens the installer. The macOS release workflow creates the DMG from a temporary staging directory containing the app and an Applications symlink. ChangesInstaller download and DMG packaging
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request renames the downloadAndInstall() method to downloadAndOpenInstaller() in UpdateChecker.swift and updates its call site in MenuBarView.swift. The reviewer noted that downloadAndOpenInstaller() is asynchronous but lacks @MainActor isolation, which can lead to UI state updates and AppKit calls running on a background thread. It is recommended to mark this method with @MainActor to prevent potential runtime issues or SwiftUI warnings.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Improves the macOS update experience by making the in-app downloaded DMG behave like a conventional “drag to Applications” installer, and aligns internal naming with the actual update action.
Changes:
- Renamed the updater action to reflect “download + open installer” behavior.
- Updated the menu bar update button to call the renamed updater action.
- Adjusted the release DMG build step to package
Insomnia.appalongside an/Applicationsshortcut.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/Insomnia/Views/MenuBarView.swift | Updates the update button to call the renamed updater method. |
| Sources/Insomnia/Update/UpdateChecker.swift | Renames the updater method and updates section labeling to match behavior. |
| .github/workflows/build.yml | Builds DMGs from a staging folder containing both the app bundle and an /Applications shortcut. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Insomnia.appbeside an/Applicationsshortcut in release DMGsWhy
The in-app download opened a bare disk image containing only
Insomnia.app, leaving users without a clear installation path.User impact
Downloaded updates now open as a conventional macOS installer where the app can be dragged to Applications.
Validation
actionlint .github/workflows/build.ymlswift build -Xswiftc -strict-concurrency=completeswift test(133 tests)Insomnia.appand the/ApplicationsshortcutSummary by CodeRabbit