Skip to content

Fix update DMG installation flow #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GordonBeeming merged 3 commits into from
Jul 15, 2026
Merged

Fix update DMG installation flow #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d58997
Add Applications shortcut to update DMG
GordonBeeming Jul 15, 2026
0c932cb
Isolate installer updates to the main actor
GordonBeeming Jul 15, 2026
28fa77c
Reset DMG staging before packaging
GordonBeeming Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,16 @@ jobs:
run: |
VERSION="${GITHUB_REF_NAME#v}"
DMG="Distribution/Insomnia-${VERSION}.dmg"
DMG_ROOT="${RUNNER_TEMP}/insomnia-dmg"

rm -rf "${DMG_ROOT}"
mkdir -p "${DMG_ROOT}"
ditto Distribution/Insomnia.app "${DMG_ROOT}/Insomnia.app"
ln -s /Applications "${DMG_ROOT}/Applications"

hdiutil create \
-volname "Insomnia" \
-srcfolder Distribution/Insomnia.app \
-srcfolder "${DMG_ROOT}" \
-ov \
-format UDZO \
"${DMG}"
Expand Down
5 changes: 3 additions & 2 deletions Sources/Insomnia/Update/UpdateChecker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,14 +151,15 @@ final class UpdateChecker {
}
}

// MARK: - Download and Install
// MARK: - Download Update

/// Downloads the latest DMG and opens it for the user to install.
///
/// The DMG is saved to `~/Downloads` and automatically mounted
/// via `NSWorkspace` so the user can drag the app to Applications.
/// File I/O is performed off the main thread to avoid UI jank.
func downloadAndInstall() async {
@MainActor
func downloadAndOpenInstaller() async {
Comment thread
GordonBeeming marked this conversation as resolved.
guard let url = downloadURL else {
lastError = "No download URL available"
return
Expand Down
2 changes: 1 addition & 1 deletion Sources/Insomnia/Views/MenuBarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ struct MenuBarView: View {
} else if updateChecker.downloadURL != nil {
// DMG available — offer direct download
Button("Download v\(version)") {
Task { await updateChecker.downloadAndInstall() }
Task { await updateChecker.downloadAndOpenInstaller() }
}
} else {
// Update exists but no DMG asset — show version info only
Expand Down
Loading