Introduce SystemAccessUtils to all Security Manager permission checks - #1700
Open
taoliult wants to merge 1 commit into
Open
Introduce SystemAccessUtils to all Security Manager permission checks#1700taoliult wants to merge 1 commit into
taoliult wants to merge 1 commit into
Conversation
taoliult
requested review from
JinhangZhang,
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
August 13, 2026 21:24
jasonkatonica
requested changes
Aug 14, 2026
Centralize all security manager permission checks in SystemAccessUtils wrapper methods instead of AccessController.doPrivileged() calls throughout the codebase. SystemAccessUtils now wraps all permission-requiring operations: - System property access (getSystemProperty) - File system access (fileExists, newFileReader, getFileCanonicalPath) - Library loading (loadLibrary) - Class loading (forName) This centralizes permission checks in one utility class, making the codebase cleaner and easier to maintain across JDK versions (SecurityManager in JDK 21 and earlier, removed AccessController.doPrivileged() in JDK 25+). Signed-off-by: Tao Liu <tao.liu@ibm.com>
taoliult
force-pushed
the
main_SecurityManager
branch
from
August 14, 2026 18:48
4a2a561 to
4ced49d
Compare
johnpeck-us-ibm
approved these changes
Aug 17, 2026
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize all security manager permission checks in SystemAccessUtils wrapper methods instead of AccessController.doPrivileged() calls throughout the codebase.
SystemAccessUtils now wraps all permission-requiring operations:
This centralizes permission checks in one utility class, making the codebase cleaner and easier to maintain across JDK versions (SecurityManager in JDK 21 and earlier, removed AccessController.doPrivileged() in JDK 25+).