Qualify issue references in registration release notes#125
Merged
Conversation
The release-notes subject is the package's squash-merge commit subject, which usually ends in a bare `#123` PR reference. That text is rendered in a foreign repo (the local registry PR, or the General PR via JuliaRegistrator), where `#123` auto-links to that repo's own issue #123 instead of the package's PR. Qualify the reference with the source repo from `GITHUB_REPOSITORY` so it resolves where it was written. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registration release notes carry the registered package's squash-merge commit subject, which usually ends in a bare
#123PR reference. That text is then rendered in a different repo (the local registry PR, or the General PR via JuliaRegistrator), where GitHub resolves#123against that repo, linking to an unrelated issue instead of the package's own PR. This qualifies any bare#Nin the subject with the source repo fromGITHUB_REPOSITORY(so#123becomesowner/repo#123), which resolves correctly wherever the notes are shown. Already-qualifiedowner/repo#Nreferences and non-issue uses of#are left alone.