Skip to content

Qualify issue references in registration release notes #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfishman merged 1 commit into from
Jun 24, 2026
Merged

Qualify issue references in registration release notes #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/actions/version-helpers/version_helpers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,15 @@ function registrator_metadata(;
readchomp(`git -C $package_path log -1 --pretty=%s HEAD`),
['\n', '\r'] => ' '
)
# The subject becomes release-notes text rendered in a foreign repo (the
# local registry PR, or the General PR via JuliaRegistrator), where a bare
# `#123` from the package's squash-merge subject would auto-link to that
# repo's issue #123 instead of the package's. Qualify it with the source
# repo so the reference resolves where it was written.
repo = get(ENV, "GITHUB_REPOSITORY", "")
if !isempty(repo)
subject = replace(subject, r"(?<![\w/])#(\d+)" => SubstitutionString("$repo#\\1"))
end

if isempty(old_ref) || old_ref == "0000000000000000000000000000000000000000"
old_ref = try
Expand Down