Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/loopover-engine/src/signals/engine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4520,7 +4520,7 @@ export function formatRiskValueQuadrant(
/** Builds the optional "Improvement" row, or `null` when the caller has no improvement data to show. `null`
* here (rather than a placeholder row) is what keeps `allRows`/`buildPublicPrPanelSignalRows`'s `rows`
* byte-identical to today for every existing caller that doesn't pass `improvementSignal` -- see the
* `KEYS`/`toHaveLength(7)` assertions in signals-coverage.test.ts, which assume a fixed 7-row table. Defense
* `KEYS`/`toHaveLength(7)` assertions in signals-edge-cases.test.ts, which assume a fixed 7-row table. Defense
* in depth (#4744 requirement, epic #4737): both the deterministic findings and the LLM rationale are
* re-checked against `containsPrivatePublicTerm` here even though `improvement.ts`'s findings are safe by
* construction (integers interpolated into a fixed template) and the LLM rationale already passed
Expand Down
2 changes: 1 addition & 1 deletion test/unit/feasibility-gate-branches.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
import { buildPreStartCheck } from "../../src/signals/engine";
import type { IssueRecord, PullRequestRecord, RegistryRepoConfig, RepositoryRecord } from "../../src/types";

// Record builders mirror test/unit/signals-coverage.test.ts so parity cases reuse the same fixture shape.
// Record builders mirror test/unit/signals-edge-cases.test.ts so parity cases reuse the same fixture shape.
function repo(fullName: string, overrides: Partial<RegistryRepoConfig> = {}): RepositoryRecord {
const [owner, name] = fullName.split("/") as [string, string];
return {
Expand Down
2 changes: 1 addition & 1 deletion test/unit/queue-4.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2950,7 +2950,7 @@ describe("queue processors", () => {
// takes its TRUE arm: every other existing test leaves the feature off (the default), which already covers the
// FALSE arm thousands of times over. Proves the deterministic tier threads end to end into a real posted
// comment, not just in the isolated `buildPublicPrPanelSignalRows`/`buildStructuralImprovementAssessment` unit
// tests (signals-coverage.test.ts).
// tests (signals-edge-cases.test.ts).
it("#4744: threads the improvement-signal row into the unified comment when the converged feature resolves on", async () => {
const env = createTestEnv({
GITHUB_APP_PRIVATE_KEY: await generatePrivateKeyPem(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ import type {
ScoringModelSnapshotRecord,
} from "../../src/types";

describe("signal coverage edge cases", () => {
// Deep edge-case and regression coverage across many src/signals/engine builders (label audit,
// preflight, public panel rendering, duplicate-winner suppression, reward/risk scoring, ...) --
// distinct from signals.test.ts's core builder suite and signals-v2.test.ts's newer-builder suite.
// Not a Codecov bolt-on: every case here targets a specific real scenario/regression, verified
// against the other two files with zero title or assertion overlap found (see #8576).
describe("signals engine edge cases", () => {
it("branches lane, label, config, and public comment publishing decisions", () => {
const directRepo = repo("owner/direct", { issueDiscoveryShare: 0, labelMultipliers: { bug: 1.2 }, trustedLabelPipeline: true });
const issueRepo = repo("owner/issues", { issueDiscoveryShare: 1 });
Expand Down