test(signals): rename signals-coverage.test.ts, scope down the signals consolidation#8586
Conversation
…consolidation Investigated merging signals.test.ts + signals-v2.test.ts + signals-coverage.test.ts per #8576. Found no real duplication to dedupe: across all ~148 top-level test cases in the trio, zero title collisions, and spot-checking similarly-named pairs (e.g. "audits configured labels..." vs "audits label ordering...") confirmed they test different functions entirely (buildConfigQuality vs buildLabelAudit). signals-v2.test.ts genuinely covers newer builders (buildCollisionEdges, buildContributorPatternReport, buildMaintainerPacket, buildRoleContext) absent from signals.test.ts -- organic API growth, not lazy duplication. A forced 6,255-line merge would be pure structural churn with real risk (import/identifier collisions across three large files) and no dedup benefit, so scoped this down to the honest, warranted action: only signals-coverage.test.ts actually matches the epic's *-coverage.test.ts anti-pattern (the file #8580's guard will block going forward). Renamed to signals-edge-cases.test.ts, retitled its top-level describe, and updated the three cross-file comments that referenced the old filename (feasibility-gate-branches.test.ts, queue-4.test.ts, signals/engine.ts). signals.test.ts and signals-v2.test.ts are left untouched.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | f69592f | Commit Preview URL Branch Preview URL |
Jul 24 2026, 10:49 PM |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8586 +/- ##
==========================================
- Coverage 92.54% 92.54% -0.01%
==========================================
Files 796 796
Lines 79850 79850
Branches 24135 24135
==========================================
- Hits 73899 73895 -4
Misses 4802 4802
- Partials 1149 1153 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-24 22:47:21 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionPartially addressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #8576.
Summary
Investigated merging
signals.test.ts+signals-v2.test.ts+signals-coverage.test.tsper #8576. Found no real duplication to dedupe: across all ~148 top-level test cases in the trio, zero title collisions, and spot-checking similarly-named pairs (e.g. "audits configured labels..." vs "audits label ordering...") confirmed they test different functions entirely (buildConfigQualityvsbuildLabelAudit).signals-v2.test.tsgenuinely covers newer builders (buildCollisionEdges,buildContributorPatternReport,buildMaintainerPacket,buildRoleContext) absent fromsignals.test.ts— organic API growth, not lazy duplication.A forced 6,255-line merge would be pure structural churn with real risk (import/identifier collisions across three large files, same class of risk as #8584 but 3x the size) and zero dedup benefit, so I scoped this down to the action actually warranted: only
signals-coverage.test.tsmatches the epic's*-coverage.test.tsanti-pattern that #8580's guard will block going forward. Renamed tosignals-edge-cases.test.ts, retitled its top-level describe, and updated the three cross-file comments that referenced the old filename.signals.test.tsandsignals-v2.test.tsare left untouched — they're legitimately organized.Test plan
npx vitest run test/unit/signals-edge-cases.test.ts test/unit/signals.test.ts test/unit/signals-v2.test.ts test/unit/feasibility-gate-branches.test.ts— 185/185 passnpm run typecheck— clean