don't depwarn while holding the typeinf lock#830
Closed
simeonschaub wants to merge 1 commit into
Closed
Conversation
This causes a context switch, which I believe is illegal while holding the typeinf lock. This caused hangs in the CoolPDLP.jl test suite on Julia 1.10
maleadt
requested changes
Jun 4, 2026
maleadt
added a commit
that referenced
this pull request
Jun 5, 2026
`Base.depwarn` logs through the active logger, and the I/O involved can switch tasks. That is illegal while holding the typeinf lock, which our `@locked` compilation entry points do on Julia 1.10/1.11, and caused hangs (#830). Replace it with `safe_depwarn`, which writes the warning synchronously to `Core.stderr` like `@safe_warn` does. Caller attribution, warning once per call site, and throwing under `--depwarn=error` still behave like `Base.depwarn`; on 1.12+, where compilation doesn't hold the typeinf lock, it just forwards there. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maleadt
added a commit
that referenced
this pull request
Jun 5, 2026
`Base.depwarn` logs through the active logger, and the I/O involved can switch tasks. That is illegal while holding the typeinf lock, which our `@locked` compilation entry points do on Julia 1.10/1.11, and caused hangs (#830). Replace it with `safe_depwarn`, which writes the warning synchronously to `Core.stderr` like `@safe_warn` does. Caller attribution, warning once per call site, and throwing under `--depwarn=error` still behave like `Base.depwarn`; on 1.12+, where compilation doesn't hold the typeinf lock, it just forwards there. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maleadt
added a commit
that referenced
this pull request
Jun 6, 2026
`Base.depwarn` logs through the active logger, and the I/O involved can switch tasks. That is illegal while holding the typeinf lock, which our `@locked` compilation entry points do on Julia 1.10/1.11, and caused hangs (#830). Replace it with `safe_depwarn`, which writes the warning synchronously to `Core.stderr` like `@safe_warn` does. Caller attribution, warning once per call site, and throwing under `--depwarn=error` still behave like `Base.depwarn`; on 1.12+, where compilation doesn't hold the typeinf lock, it just forwards there. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes a context switch, which I believe is illegal while holding the typeinf lock. This caused hangs in the CoolPDLP.jl test suite on Julia 1.10