Skip to content

don't depwarn while holding the typeinf lock #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simeonschaub wants to merge 1 commit into from
Closed

don't depwarn while holding the typeinf lock #830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/driver.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,14 +325,14 @@ const __llvm_initialized = Ref(false)
# target-specific libraries
@tracepoint "target libraries" begin
if has_legacy_link_libraries(job)
Base.depwarn(
"3-arg `link_libraries!(job, mod, undefined_fns)` is deprecated; " *
"migrate your override to the 2-arg form `link_libraries!(job, mod)`. " *
"Instead of inspecting `undefined_fns` to decide what to link, " *
"parse the library lazily with `parse(LLVM.Module, bytes; lazy=true)` " *
"and link it with `LLVM.link!(mod, lib; only_needed=true)` — " *
"the linker will then materialize only the referenced symbols.",
:link_libraries!)
#Base.depwarn(
# "3-arg `link_libraries!(job, mod, undefined_fns)` is deprecated; " *
# "migrate your override to the 2-arg form `link_libraries!(job, mod)`. " *
# "Instead of inspecting `undefined_fns` to decide what to link, " *
# "parse the library lazily with `parse(LLVM.Module, bytes; lazy=true)` " *
# "and link it with `LLVM.link!(mod, lib; only_needed=true)` — " *
# "the linker will then materialize only the referenced symbols.",
# :link_libraries!)
undefined_fns = [LLVM.name(f) for f in functions(ir)
if isdeclaration(f) && !LLVM.isintrinsic(f)]
link_libraries!(job, ir, undefined_fns)
Expand Down
Loading