Fix ListTest.testAuditDetailRejectsRowIdFromOtherList#3111
Merged
labkey-bpatel merged 2 commits intoJul 15, 2026
Conversation
getRowIndex(String) matches on primary-key value (the .select checkbox), not on a column value. LIST_Y is an IntList keyed on Key, so passing the Name value returned -1 and blew up in DataRegionTable.updateLink. Use the (columnIdentifier, value) overload against NAME_FIELD instead.
exp schema has no Lists query; the list module exposes list metadata through ListManager.ListManager. Matches the resolveListId pattern in ListMoveRowsTest.
DariaBod
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Regression test failure for list audit detail:
https://teamcity.labkey.org/buildConfiguration/LabKey_263Release_Community_DailyPostgres2/4091141?buildTab=tests&name=org.labkey.test.tests.list.ListTest.testAuditDetailRejectsRowIdFromOtherList
Related Pull Requests
Changes
ListTest.java:906— use the(columnIdentifier, value)overload ofgetRowIndexagainstNAME_FIELDinstead of the PK-basedgetRowIndex(String).ListTest.java:937-943— look up the list'sListIdviaSelectRowsCommand("ListManager", "ListManager")