Skip to content

Fix ListTest.testAuditDetailRejectsRowIdFromOtherList #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-bpatel merged 2 commits into from
Jul 15, 2026
Merged

Fix ListTest.testAuditDetailRejectsRowIdFromOtherList #3111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2999372
Fix row lookup in testAuditDetailRejectsRowIdFromOtherList
labkey-bpatel Jul 14, 2026
0b86ffb
Look up list id via ListManager query, not exp.Lists
labkey-bpatel Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/org/labkey/test/tests/list/ListTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ public void testAuditDetailRejectsRowIdFromOtherList() throws Exception
.setText(NAME_FIELD + "\n" + LIST_Y_ROW_VALUE)
.submit();
DataRegionTable yTable = new DataRegionTable("query", getDriver());
yTable.clickEditRow(yTable.getRowIndex(LIST_Y_ROW_VALUE));
yTable.clickEditRow(yTable.getRowIndex(NAME_FIELD, LIST_Y_ROW_VALUE));
setFormElement(Locator.name("quf_" + NAME_FIELD), LIST_Y_ROW_EDITED);
clickButton("Submit");

Expand Down Expand Up @@ -934,13 +934,13 @@ public void testAuditDetailRejectsRowIdFromOtherList() throws Exception

private int lookupListId(Connection cn, String listName) throws Exception
{
SelectRowsCommand cmd = new SelectRowsCommand("exp", "Lists");
cmd.setColumns(List.of("RowId", "Name"));
SelectRowsCommand cmd = new SelectRowsCommand("ListManager", "ListManager");
cmd.setColumns(List.of("ListId", "Name"));
cmd.addFilter(new Filter("Name", listName, Filter.Operator.EQUAL));
SelectRowsResponse rs = cmd.execute(cn, getProjectName());
if (rs.getRows().isEmpty())
throw new AssertionError("No exp.Lists row for " + listName);
return ((Number) rs.getRows().get(0).get("RowId")).intValue();
throw new AssertionError("No ListManager row for " + listName);
return ((Number) rs.getRows().get(0).get("ListId")).intValue();
}

private int lookupListAuditRowId(Connection cn, String listName) throws Exception
Expand Down