test(agent-core-v2): retry Windows cleanup, increase slow-test timeouts - #2792
Conversation
|
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 200dc2f079
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- workspaceResources.test.ts: retry fs.rm on transient Windows EBUSY/EPERM errors after handles close. - op-uniqueness.test.ts / vendor-name-gates.test.ts: increase timeouts for full src/ scans that can take ~9s on slow bind-mounted filesystems. - configManifest.test.ts / wireManifest.test.ts: increase manifest-generation timeouts beyond the previous 60s budget. - tool.test.ts: give one subagent-spawn test more headroom under parallel load in constrained containers. - Retry recursive temp-home cleanup on transient ENOTEMPTY/EBUSY using Node's linear backoff defaults (maxRetries: 5, retryDelay: 100). - Extract cleanupHomeDir() so four afterEach blocks share the same retrying cleanup.
200dc2f to
52fff9a
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Signed-off-by: Sampson <jjdsampson@gmail.com>
1 participant
Problem
Some
agent-core-v2tests are flaky or fail in Windows/Docker environments due to transient filesystem cleanup errors and timeouts that are too aggressive for slow bind-mounted filesystems or resource-constrained containers.In particular, Windows can briefly keep files, directories, or process pipes busy after they are closed, causing recursive cleanup to fail with
EBUSY,EPERM, orENOTEMPTY. Several filesystem-heavy tests can also legitimately exceed their current timeout budgets under slower I/O or parallel load.What changed
EBUSY,EPERM, andENOTEMPTYerrors.cleanupHomeDir()where the same retry behavior was needed across multiple tests.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.