Skip to content

⚡ Bolt: [performance improvement] Optimize string replacements in FileNameEvaluation#272

Open
RoiSoleil wants to merge 1 commit intomasterfrom
bolt/optimize-filenameevaluation-14014025370469232741
Open

⚡ Bolt: [performance improvement] Optimize string replacements in FileNameEvaluation#272
RoiSoleil wants to merge 1 commit intomasterfrom
bolt/optimize-filenameevaluation-14014025370469232741

Conversation

@RoiSoleil
Copy link
Copy Markdown
Contributor

💡 What: Optimized string replacements in FileNameEvaluation by replacing Matcher.replaceAll using regex with literal String.replace operations.
🎯 Why: In modern JDKs (this project targets Java 21), String.replace is heavily optimized for literal replacements and bypasses the regex execution engine, avoiding the overhead of Matcher instantiation.
📊 Impact: Reduces overhead during filename parsing and evaluation.
🔬 Measurement: Verified the functional correctness of filename matching patterns by ensuring FileNameEvaluationTest and the overall org.moreunit.core.test test suite passes. Checkstyle rules were validated to ensure code compliance.


PR created automatically by Jules for task 14014025370469232741 started by @RoiSoleil

Optimized string replacements in `FileNameEvaluation` by swapping `Matcher.replaceAll` with literal `String.replace`. In modern JDKs, `String.replace` is heavily optimized and avoids the overhead of instantiating `Matcher` objects and running the regex execution engine when performing literal character substitutions.

* Removed unused regex `Pattern` static constants.
* Updated inline documentation.
* Verified that tests still pass completely.

Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.12%. Comparing base (3d45358) to head (08e85b0).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
- Coverage     75.13%   75.12%   -0.01%     
+ Complexity     3313     3312       -1     
============================================
  Files           422      422              
  Lines         14568    14565       -3     
  Branches       1270     1270              
============================================
- Hits          10945    10942       -3     
  Misses         3090     3090              
  Partials        533      533              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant