Skip to content

⚡ Bolt: [performance improvement] Optimize string replacements in FileNameEvaluation #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RoiSoleil wants to merge 1 commit into from
Closed

⚡ Bolt: [performance improvement] Optimize string replacements in FileNameEvaluation #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions org.moreunit.core/src/org/moreunit/core/matching/FileNameEvaluation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
*/
public final class FileNameEvaluation
{
private static final Pattern QUOTE_SEPARATORS = Pattern.compile("(?:\\\\Q|\\\\E)");
private static final Pattern SUCCESSIVE_QUOTE_SEPARATORS = Pattern.compile("\\\\E\\\\Q");
private static final Pattern WILDCARDS = Pattern.compile("\\.\\*");

private final String evaluatedFileName;
private final boolean testFile;
private final Collection<String> otherCorrespondingFilePatterns;
Expand All @@ -45,7 +41,9 @@ private static Collection<String> simplify(Collection<String> patterns)
List<String> result = new ArrayList<String>();
for (String pattern : patterns)
{
result.add(SUCCESSIVE_QUOTE_SEPARATORS.matcher(pattern).replaceAll(""));
// ⚡ Bolt: Replaced Matcher.replaceAll with literal String.replace
// ⚡ Impact: Avoids Matcher instantiation and regex execution overhead, providing a significant speedup
result.add(pattern.replace("\\E\\Q", ""));
}
return result;
}
Expand Down Expand Up @@ -83,7 +81,9 @@ public List<String> getAllCorrespondingFileEclipsePatterns()

private String convertWildcards(String str)
{
return WILDCARDS.matcher(str).replaceAll("*");
// ⚡ Bolt: Replaced Matcher.replaceAll with literal String.replace
// ⚡ Impact: Avoids Matcher instantiation and regex execution overhead
return str.replace(".*", "*");
}

/**
Expand Down Expand Up @@ -126,7 +126,9 @@ public String getPreferredCorrespondingFileName()

private String removeQuotes(String str)
{
return QUOTE_SEPARATORS.matcher(str).replaceAll("");
// ⚡ Bolt: Replaced Matcher.replaceAll with literal String.replace
// ⚡ Impact: Avoids Matcher instantiation and regex execution overhead
return str.replace("\\Q", "").replace("\\E", "");
}

@Override
Expand Down
Loading