Make Puzzletron examples portable - #2044
Conversation
Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
Keep the Qwen MoE runner's repository, environment, container, mount, and setup hooks visible without retaining site-specific paths. Add a regression test for the portable placeholder contract. Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughPuzzletron configuration examples now use portable paths, placeholders, optional defaults, and public Hugging Face model identities. Setup documentation and wizard prompts describe the corresponding infrastructure settings. Regression tests validate configuration portability and loadability. ChangesPuzzletron portability
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/puzzletron/configs/families/qwen3_5/qwen3p5_9b/model.yaml`:
- Around line 7-8: Pin the Qwen 3.5 9B configuration by adding its validated
immutable Hugging Face commit to model_info.hf_revision in
examples/puzzletron/configs/families/qwen3_5/qwen3p5_9b/model.yaml. Update the
portable-config test in tests/unit/torch/puzzletron/test_portable_configs.py to
require every model example to define a non-empty immutable revision.
In `@examples/puzzletron/README.md`:
- Line 25: Update the sentence in the README so the comma following “evaluation
results” is replaced with a semicolon or period, preserving the surrounding
wording.
In `@puzzletron_setup/wizard.py`:
- Around line 1214-1220: Update the repository path prompt in the wizard flow to
use the repository-relative default "." instead of deriving the controller’s
absolute working directory via Path.cwd(). Keep the existing prompt text,
description, and support for user-provided shared absolute paths unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6737a750-6c4d-4b56-9764-f28f9e69536f
📒 Files selected for processing (12)
examples/puzzletron/README.mdexamples/puzzletron/configs/families/nemotron3/nano_30b_a3b_bf16/model.yamlexamples/puzzletron/configs/families/qwen3_5/qwen3p5_9b/model.yamlexamples/puzzletron/configs/families/qwen3_5/qwen3p6_35b_a3b/model.yamlexamples/puzzletron/configs/orchestration/execution.example.yamlexamples/puzzletron/configs/orchestration/qwen_moe/runner.slurm.yamlexamples/puzzletron/configs/orchestration/runner.baremetal.example.yamlexamples/puzzletron/configs/orchestration/runner.slurm.example.yamlexamples/puzzletron/configs/setup/defaults.example.yamlnv-internal/sepehr_defaults.yamlpuzzletron_setup/wizard.pytests/unit/torch/puzzletron/test_portable_configs.py
💤 Files with no reviewable changes (1)
- nv-internal/sepehr_defaults.yaml
Signed-off-by: Johannes Rausch <jrausch@nvidia.com>
What does this PR do?
Type of change: Bug fix
Puzzletron v2 examples contain site-specific paths and defaults that do not work for other contributors. This change makes the checked-in examples portable:
Usage
Copy the example and add the scheduler, container, data, and mount values required by your environment before using it for a campaign.
Testing
Covered by Puzzletron configuration and lightweight orchestration CI tests.
Summary by CodeRabbit
Documentation
Improvements
Tests