-
Notifications
You must be signed in to change notification settings - Fork 522
Make Puzzletron examples portable #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
j-rausch
wants to merge
7
commits into
feature/puzzletron_v2
Choose a base branch
from
jrausch/puzzletron-v2-config-portability
base: feature/puzzletron_v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
89b4bb4
Make Puzzletron examples portable
j-rausch 940e5f1
Refine portable Puzzletron examples
j-rausch 848f7c5
Clarify Puzzletron example inputs
j-rausch 3c8ef29
Restore Qwen Slurm execution placeholders
j-rausch 63a89ff
Tighten portable configuration tests
j-rausch 99326c5
Move defaults example and tighten portability tests
j-rausch 66d59ff
Address Puzzletron portability review feedback
j-rausch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
examples/puzzletron/configs/families/nemotron3/nano_30b_a3b_bf16/model.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
examples/puzzletron/configs/families/qwen3_5/qwen3p5_9b/model.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
examples/puzzletron/configs/families/qwen3_5/qwen3p6_35b_a3b/model.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
examples/puzzletron/configs/orchestration/execution.example.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 15 additions & 7 deletions
22
examples/puzzletron/configs/orchestration/runner.baremetal.example.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,27 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Example bare-metal runner config for the v2 orchestrator.""" | ||
| # Example bare-metal runner config for the v2 orchestrator. | ||
|
|
||
| runner: | ||
| kind: baremetal | ||
| inventory: | ||
| rendezvous_host: node-a | ||
| # Required placeholders. Replace both host values with SSH hosts reachable | ||
| # from the controller; the rendezvous host must match one inventory hostname. | ||
| rendezvous_host: REPLACE_WITH_PRIMARY_HOST | ||
| rendezvous_port_base: 29500 | ||
| hosts: | ||
| - hostname: node-a | ||
| - hostname: REPLACE_WITH_PRIMARY_HOST | ||
| gpus: 8 | ||
| - hostname: node-b | ||
| - hostname: REPLACE_WITH_SECONDARY_HOST | ||
| gpus: 8 | ||
| execution_contract: | ||
| repository: /shared/modelopt | ||
| venv: /shared/modelopt/.venv | ||
| setup_env: "" | ||
| # Runnable when the same checkout is visible on every SSH host. | ||
| # Otherwise, replace "." with the repository path shared by those hosts. | ||
| repository: . | ||
| # Sourced as <venv>/bin/activate after changing into the repository. | ||
| # Use a repository-relative path or an absolute path visible on every host. | ||
| venv: .venv | ||
| # Optional script sourced before virtualenv activation on every host. | ||
| # Leave null when the worker login environment needs no additional setup. | ||
| setup_env: null |
30 changes: 21 additions & 9 deletions
30
examples/puzzletron/configs/orchestration/runner.slurm.example.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,37 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Example Slurm runner config for the v2 orchestrator.""" | ||
| # Example Slurm runner config for the v2 orchestrator. | ||
|
|
||
| runner: | ||
| kind: slurm | ||
| slurm: | ||
| account: your_account | ||
| # Required placeholder. Replace with the Slurm account for your site. | ||
| account: REPLACE_WITH_SLURM_ACCOUNT | ||
| # Replace these generic partition names if your site uses different names. | ||
| partition: batch | ||
| partition_interactive: interactive | ||
| partition_batch: batch | ||
| # Optional. CPU/IO stages fall back to one GPU when omitted. | ||
| # Optional. CPU/IO stages use the regular one-node partition when unset. | ||
| partition_cpu: null | ||
| interactive_max_nodes: 2 | ||
| time_limit: "4:00:00" | ||
| log_dir: puzzle_runs/logs | ||
| execution_contract: | ||
| repository: /shared/modelopt | ||
| venv: /shared/modelopt/.venv | ||
| container: /path/to/container.sqsh | ||
| container_mounts: /shared:/shared | ||
| prerun_commands: | ||
| - source /path/to/site-setup.sh | ||
| # Runnable when orchestration starts from a checkout visible on every worker. | ||
| # Otherwise, replace "." with the worker-visible repository path. | ||
| repository: . | ||
| # Sourced as <venv>/bin/activate after changing into the repository. | ||
| # Use a repository-relative path or an absolute path visible on every worker. | ||
| venv: .venv | ||
| # Optional. Set to an image/path accepted by the cluster's srun container plugin. | ||
| # Leave null to execute directly in the worker environment. | ||
| container: null | ||
| # Optional and used only with a container. Use comma-separated | ||
| # /host/path:/container/path entries, for example /data:/data,/models:/models. | ||
| container_mounts: null | ||
| # Optional shell commands run in order before virtualenv activation. | ||
| # Example: ["module load cuda", "export HF_HOME=/data/huggingface"] | ||
| prerun_commands: [] | ||
| # Optional shell commands run when the stage payload exits. | ||
| postrun_commands: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| schema_version: 1 | ||
| infrastructure: | ||
| execution_contract: | ||
| # Runnable when setup and orchestration start from a checkout visible on every worker. | ||
| # Otherwise, replace "." with the worker-visible repository path. | ||
| repository: . | ||
| # Sourced as <venv>/bin/activate after changing into the repository. | ||
| # Use a repository-relative path or an absolute path visible on every worker. | ||
| venv: .venv | ||
| # Optional. Set to an image/path accepted by the cluster's srun container plugin. | ||
| # Leave null to execute directly in the worker environment. | ||
| container: null | ||
| # Optional and used only with a container. Use comma-separated | ||
| # /host/path:/container/path entries, for example /data:/data,/models:/models. | ||
| container_mounts: null | ||
| # Optional shell commands run in order before virtualenv activation. | ||
| # Example: ["module load cuda", "export HF_HOME=/data/huggingface"] | ||
| prerun_commands: [] | ||
| runner: | ||
| kind: slurm | ||
| slurm: | ||
| # Add the required Slurm account for your site before using this file. | ||
| # account: REPLACE_WITH_SLURM_ACCOUNT | ||
| # Optional. CPU/IO stages use the regular partition when unset. | ||
| partition_cpu: null |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.