[FIX] test-requirements: pin max supported version for fsspec deps#603
Conversation
|
Hi @lmignon, |
|
@lmignon can you pls review the versions for |
Hi Simone, Thank you for the PR. Having different versions of the same library should not be an issue. Python will install the higher version, so there is no need to align them. Have you encountered any problems? |
|
Ciao! :) |
|
@lmignon gentle ping for a review :) |
|
@simahawk In my view, it’s not a good idea to try to standardise the minimum required version of fsspecs across all modules. This involves specific API changes required by each module independently of the others, but which are not required by all. Could you please remove the commit that aligns the fsspecs version? Once that’s done, I’ll be able to merge the changes. |
|
I understand your pt and I can remove the commit. However, in this CI you never test w/ the version pinned for the specific module. |
|
I moved that part to #607 |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
thank you @simahawk ! |
|
Congratulations, your PR was merged at 49d69d5. Thanks a lot for contributing to OCA. ❤️ |
Tries to fix #602
There were 3 modules w/ 3 different versions of fsspec + no cap on test deps.
Collateral fix: remove obsolete
setupfolder.