Skip to content

[FIX] test-requirements: pin max supported version for fsspec deps#603

Merged
OCA-git-bot merged 2 commits into
OCA:18.0from
camptocamp:18-fix-build
May 20, 2026
Merged

[FIX] test-requirements: pin max supported version for fsspec deps#603
OCA-git-bot merged 2 commits into
OCA:18.0from
camptocamp:18-fix-build

Conversation

@simahawk
Copy link
Copy Markdown
Contributor

Tries to fix #602

There were 3 modules w/ 3 different versions of fsspec + no cap on test deps.

Collateral fix: remove obsolete setup folder.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:fs_storage Module fs_storage series:18.0 mod:fs_storage_ms_drive Module fs_storage_ms_drive labels May 13, 2026
@simahawk
Copy link
Copy Markdown
Contributor Author

@lmignon can you pls review the versions for fsspec?

@lmignon
Copy link
Copy Markdown
Contributor

lmignon commented May 13, 2026

@lmignon can you pls review the versions for fsspec?

Hi Simone,

Thank you for the PR. Having different versions of the same library should not be an issue. Python will install the higher version, so there is no need to align them. Have you encountered any problems?

@simahawk
Copy link
Copy Markdown
Contributor Author

simahawk commented May 13, 2026

Ciao! :)
That's not the problem it's just that is confusing to have 3 versions in requirements.txt.
I've done that while solving the problem of the other dependencies. See #602

@simahawk
Copy link
Copy Markdown
Contributor Author

@lmignon gentle ping for a review :)

@lmignon
Copy link
Copy Markdown
Contributor

lmignon commented May 20, 2026

@simahawk In my view, it’s not a good idea to try to standardise the minimum required version of fsspecs across all modules. This involves specific API changes required by each module independently of the others, but which are not required by all. Could you please remove the commit that aligns the fsspecs version? Once that’s done, I’ll be able to merge the changes.

@simahawk
Copy link
Copy Markdown
Contributor Author

simahawk commented May 20, 2026

I understand your pt and I can remove the commit. However, in this CI you never test w/ the version pinned for the specific module.
And if you use 2 modules in your installation, you'll have to choose one.

@simahawk
Copy link
Copy Markdown
Contributor Author

I moved that part to #607

@simahawk simahawk changed the title [FIX] fs_storage*: align fsspec ext req version [FIX] test-requirements: pin max supported version for fsspec deps May 20, 2026
Copy link
Copy Markdown

@ArnauCForgeFlow ArnauCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmignon
Copy link
Copy Markdown
Contributor

lmignon commented May 20, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-603-by-lmignon-bump-nobump, awaiting test results.

@lmignon
Copy link
Copy Markdown
Contributor

lmignon commented May 20, 2026

thank you @simahawk !

@OCA-git-bot OCA-git-bot merged commit 49d69d5 into OCA:18.0 May 20, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 49d69d5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[18.0] build broken

4 participants