Skip to content

Resolve Zarr config annotations from their nominal owner - #4

Merged
trissim merged 1 commit into
mainfrom
codex/zarr-config-type-binding
Jul 30, 2026
Merged

Resolve Zarr config annotations from their nominal owner#4
trissim merged 1 commit into
mainfrom
codex/zarr-config-type-binding

Conversation

@trissim

@trissim trissim commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • bind ZarrConfig once at the PolyStore module boundary
  • remove method-local imports that made the quoted type annotation unresolved
  • add a regression proving runtime type reflection resolves the authoritative config class

Verification

  • 31 passed, 13 skipped in the Zarr and OME-Zarr focused suites
  • focused Ruff undefined/import checks passed
  • wheel and sdist built successfully
  • twine check passed

Copilot AI review requested due to automatic review settings July 30, 2026 19:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Risk Analyzer Agent🛡️

Risk Analysis 🛡️ · Low Risk

✅ Approved — Low-Risk Change

Details
  • Hoists from .config import ZarrConfig to module scope and drops two redundant method-local imports. config.py imports only the external metaclass_registry package and stdlib and never imports polystore.zarr, so no import cycle is reintroduced.
  • No runtime behavior change: the edit only makes the quoted 'ZarrConfig' annotation resolvable at runtime and bumps the package version 0.1.25 → 0.1.26.
  • The test change only adds a get_type_hints regression test; no existing test is modified or weakened.

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep Code Review Agent🐛

Review completed with 1 suggestions.

Fix in Cosmos

Comment thread pyproject.toml
[project]
name = "polystore"
version = "0.1.25"
version = "0.1.26"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the project metadata to 0.1.26 leaves polystore.__version__ at 0.1.25, and this repository's release helper updates both files together. Published/install smoke checks can therefore report the previous package version even though the wheel metadata says 0.1.26.

Severity: low


🤖 Was this useful? React with 👍 or 👎

@trissim
trissim merged commit a7db3f2 into main Jul 30, 2026
8 checks passed
@trissim
trissim deleted the codex/zarr-config-type-binding branch July 30, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants