Resolve Zarr config annotations from their nominal owner - #4
Merged
Conversation
There was a problem hiding this comment.
Risk Analysis 🛡️ · Low Risk
✅ Approved — Low-Risk Change
Details
- Hoists
from .config import ZarrConfigto module scope and drops two redundant method-local imports.config.pyimports only the externalmetaclass_registrypackage and stdlib and never importspolystore.zarr, so no import cycle is reintroduced. - No runtime behavior change: the edit only makes the quoted
'ZarrConfig'annotation resolvable at runtime and bumps the package version 0.1.25 → 0.1.26. - The test change only adds a
get_type_hintsregression test; no existing test is modified or weakened.
| [project] | ||
| name = "polystore" | ||
| version = "0.1.25" | ||
| version = "0.1.26" |
There was a problem hiding this comment.
Changing the project metadata to 0.1.26 leaves polystore.__version__ at 0.1.25, and this repository's release helper updates both files together. Published/install smoke checks can therefore report the previous package version even though the wheel metadata says 0.1.26.
Severity: low
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification