Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "polystore"
version = "0.1.25"
version = "0.1.26"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the project metadata to 0.1.26 leaves polystore.__version__ at 0.1.25, and this repository's release helper updates both files together. Published/install smoke checks can therefore report the previous package version even though the wheel metadata says 0.1.26.

Severity: low


🤖 Was this useful? React with 👍 or 👎

description = "Framework-agnostic multi-backend storage abstraction for ML and scientific computing"
readme = "README.md"
requires-python = ">=3.11"
Expand Down
6 changes: 1 addition & 5 deletions src/polystore/zarr.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ def _ensure_ome_zarr(timeout: float = 30.0):

from .constants import Backend
from .base import PicklableBackend, StorageBackend
from .config import ZarrConfig
from .exceptions import StorageResolutionError


Expand Down Expand Up @@ -137,9 +138,6 @@ def __init__(self, zarr_config: Optional['ZarrConfig'] = None):
Args:
zarr_config: ZarrConfig dataclass with all zarr settings (uses defaults if None)
"""
# Import here to avoid circular imports
from .config import ZarrConfig

if zarr_config is None:
zarr_config = ZarrConfig()

Expand All @@ -157,8 +155,6 @@ def get_connection_params(self) -> Optional[Dict[str, Any]]:
return {"zarr_config": self.config}

def set_connection_params(self, params: Optional[Dict[str, Any]]) -> None:
from .config import ZarrConfig

if params is None:
self._configure(ZarrConfig())
return
Expand Down
6 changes: 6 additions & 0 deletions tests/test_zarr_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from dataclasses import fields
from inspect import getdoc
from pathlib import Path
from typing import get_type_hints

import numpy as np
import pytest
Expand Down Expand Up @@ -250,6 +251,11 @@ def test_save_to_nonexistent_parent_creates_parent(self, zarr_backend, temp_zarr
class TestZarrConfigIntegration:
"""Test ZarrConfig integration with backend."""

def test_backend_config_annotation_resolves_to_nominal_owner(self):
hints = get_type_hints(ZarrStorageBackend._configure)

assert hints["zarr_config"] is ZarrConfig

def test_public_fields_have_declaration_help(self):
docstring = getdoc(ZarrConfig)

Expand Down
Loading