feat: pass auth tokens by reference, not value#1362
Open
jonathanlab wants to merge 1 commit into03-30-refactor_move_auth_to_mainfrom
Open
feat: pass auth tokens by reference, not value#1362jonathanlab wants to merge 1 commit into03-30-refactor_move_auth_to_mainfrom
jonathanlab wants to merge 1 commit into03-30-refactor_move_auth_to_mainfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 30, 2026
jonathanlab
force-pushed
the
03-30-refactor_move_auth_to_main
branch
from
95069b4 to
c0bb295
Compare
jonathanlab
force-pushed
the
refactor_pass_tokens_by_reference_not_by_value
branch
from
7a165a4 to
98a1093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We've split up the auth store in the previous PR into a service, but now we're not actually using it properly. A lot of services use their own (stale) local auth token value. We instead want to use the auth services token.
Changes