refactor: hook up renderer auth logic to service#1365
Open
jonathanlab wants to merge 1 commit intorefactor_pass_tokens_by_reference_not_by_valuefrom
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 30, 2026
jonathanlab
force-pushed
the
refactor_pass_tokens_by_reference_not_by_value
branch
from
7a165a4 to
98a1093
Compare
jonathanlab
force-pushed
the
03-30-refactor_hook_up_renderer_auth_logic_to_service
branch
2 times, most recently
from
ddd1bec to
f3b186c
Compare
jonathanlab
force-pushed
the
refactor_pass_tokens_by_reference_not_by_value
branch
from
98a1093 to
5cb9976
Compare
jonathanlab
force-pushed
the
03-30-refactor_hook_up_renderer_auth_logic_to_service
branch
from
f3b186c to
1e35e6d
Compare
k11kirky
approved these changes
Mar 31, 2026
jonathanlab
force-pushed
the
03-30-refactor_hook_up_renderer_auth_logic_to_service
branch
from
1e35e6d to
7255c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We've now hooked up our main services to the auth service, but the auth store is just a thin unreliable wrapper around the main service. We want to rely on trpc queries with tanstack query instead.
Changes
one test fails here (preferred org persistence), we can just forge merge with CI bypass this one since it's fixed in the next PR in the stack