Translations for the scouting app - #13
Conversation
cuttestkittensrule
left a comment
cuttestkittensrule
left a comment
There was a problem hiding this comment.
It looks like the wrong language code was used for one translation, but other than that, it looks good (though I can't vouch for the accuracy of the translations on account of not speaking the languages)
There was a problem hiding this comment.
what language is this? This has the language code for Czech.
It looks like Japaneese or Chineese; here are the language codes for them:
Chinese: zh
Japanese: ja
There was a problem hiding this comment.
its mandarin simplified let me see how to differentiate them and I'll see if I can find the proper language code
There was a problem hiding this comment.
cuase mandarin there tradiational and simplfied
There was a problem hiding this comment.
It looks like currently, compose multiplatform doesn't support having different resources for different scripts, like Hans and Hant (see https://youtrack.jetbrains.com/issue/CMP-4449/Ability-to-support-more-language-and-region-qualifiers). It does support region codes (like https://developer.android.com/guide/topics/resources/app-languages#locale-names). If we want to have both traditional and simplified, the best we can do right now is to use the regions where simplified and traditional are used.
There was a problem hiding this comment.
thanks for the research, for simplified I'll do china(rCN) and traditional Taiwan(rTW)
There was a problem hiding this comment.
We should be able to use resources for different scripts (like Hans and Hant) once Compose Multiplatform version 1.12.0 comes out, since support for it was added 3 weeks ago (so if we want to use it we just need to wait for the next release)
havent tested it yet will update if test passes or fails
| @@ -1,5 +1,5 @@ | |||
| [versions] | |||
| agp = "8.11.2" | |||
| agp = "8.13.2" | |||
There was a problem hiding this comment.
Is there a specific reason you updated AGP? According to the compatibility table, this change would drop support for Android Studio Narwhal and Android Studio Narwhal Feature Drop
There was a problem hiding this comment.
I think I clicked something to update android studio I can revert back if you want me to
There was a problem hiding this comment.
Please revert back for now.
2 participants
#12 the translations are a work in progress, don't review yet I did this to link it to the issue