-
Notifications
You must be signed in to change notification settings - Fork 0
Translations for the scouting app #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomj-1
wants to merge
7
commits into
main
Choose a base branch
from
tom-translations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ae43a0a
added some tranlations need to get update some things
tomj-1 e09c7f7
ran spotless apply
tomj-1 8ab943c
combined prematch.xml into quantiative.xml
tomj-1 3db7a99
Added language code for simplfied
tomj-1 6f5ea47
refactored to use regions for written mandarin
tomj-1 82367db
added mMandarintraditional translations
tomj-1 a196d36
added for kn translations and reverted gradle version
tomj-1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
composeApp/src/commonMain/composeResources/values-es/quantiative.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <resources> | ||
| <string name="matchNumber">¿Número de Partido?</string> | ||
| <string name="nameOfPerson">¡Tu Nombre!</string> | ||
| <string name="teamNumber">¿Número de Equipo?</string> | ||
| <string name="auto_shoot_preload">Disparo Precargado</string> | ||
| <string name="auto_fuel_outpost">Combustible del Puesto de Avanzada</string> | ||
| <string name="auto_fuel_depot">Combustible del Depósito</string> | ||
| <string name="auto_fuel_neutral">Combustible de la Zona Neutral</string> | ||
| <string name="cycles">Cycles</string> | ||
| <string name="herding">Herding</string> | ||
| <string name="incap">incapacitated</string> | ||
| </resources> |
13 changes: 13 additions & 0 deletions
13
composeApp/src/commonMain/composeResources/values-kn/quantiative.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <resources> | ||
| <!--This is kannada translations --> | ||
| <string name="matchNumber">Match sankhye enu?</string> | ||
| <string name="nameOfPerson">ninna hesarenu!</string> | ||
| <string name="teamNumber">Team sankhye eshtu?</string> | ||
| <string name="auto_shoot_preload">Shot Ready maadi</string> | ||
| <string name="auto_fuel_outpost">Outpost inda Indhana</string> | ||
| <string name="auto_fuel_depot">Depot inda Indhana</string> | ||
| <string name="auto_fuel_neutral">Nuetral Zone inda Indhana</string> | ||
| <string name="cycles">Chakra</string> | ||
| <string name="herding">Chendugalannu ottu maaduvudu</string> | ||
| <string name="incap">Asamartha</string> | ||
| </resources> |
13 changes: 13 additions & 0 deletions
13
composeApp/src/commonMain/composeResources/values-zh-rCN/quantitative.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <resources> | ||
| <!--This is mandarin simplified translations --> | ||
| <string name="matchNumber">比赛编号</string> | ||
| <string name="nameOfPerson">记录人姓名</string> | ||
| <string name="teamNumber">队伍编号</string> | ||
| <string name="auto_shoot_preload">预装弹发射数</string> | ||
| <string name="auto_fuel_outpost">来自前哨站的燃料数</string> | ||
| <string name="auto_fuel_depot">来自补给站的燃料数</string> | ||
| <string name="auto_fuel_neutral">来自中立区的燃料数</string> | ||
| <string name="cycles">Cycles</string> | ||
| <string name="herding">Herding</string> | ||
| <string name="incap">incapacitated</string> | ||
| </resources> |
14 changes: 14 additions & 0 deletions
14
composeApp/src/commonMain/composeResources/values-zh-rTW/quantitative.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <resources> | ||
| <!--This is mandarin traditional translations --> | ||
| <!--This is for emulator testing will update once I get translations --> | ||
| <string name="matchNumber">匹配號碼</string> | ||
| <string name="nameOfPerson">隊員姓名</string> | ||
| <string name="teamNumber">隊號</string> | ||
| <string name="auto_shoot_preload">射擊預裝</string> | ||
| <string name="auto_fuel_outpost">球來自隊員裝球位</string> | ||
| <string name="auto_fuel_depot">球來自取球倉</string> | ||
| <string name="auto_fuel_neutral">球來自中立區</string> | ||
| <string name="cycles">:循環次數</string> | ||
| <string name="herding">運球</string> | ||
| <string name="incap">停止運作</string> | ||
| </resources> |
5 changes: 0 additions & 5 deletions
5
composeApp/src/commonMain/composeResources/values/prematch.xml
This file was deleted.
Oops, something went wrong.
3 changes: 3 additions & 0 deletions
3
composeApp/src/commonMain/composeResources/values/quantitative.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what language is this? This has the language code for Czech.
It looks like Japaneese or Chineese; here are the language codes for them:
Chinese:
zhJapanese:
jaThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its mandarin simplified let me see how to differentiate them and I'll see if I can find the proper language code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuase mandarin there tradiational and simplfied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like currently, compose multiplatform doesn't support having different resources for different scripts, like
HansandHant(see https://youtrack.jetbrains.com/issue/CMP-4449/Ability-to-support-more-language-and-region-qualifiers). It does support region codes (like https://developer.android.com/guide/topics/resources/app-languages#locale-names). If we want to have both traditional and simplified, the best we can do right now is to use the regions where simplified and traditional are used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the research, for simplified I'll do china(rCN) and traditional Taiwan(rTW)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to use resources for different scripts (like
HansandHant) once Compose Multiplatform version 1.12.0 comes out, since support for it was added 3 weeks ago (so if we want to use it we just need to wait for the next release)