Fix examples-web-smoke serve startup and header() after stmt ?? (#10380)#10389
Merged
Conversation
…). Skip full apply-patches on php-local when markers verify (~17s), raise serve wait timeout, and stop stmt-level coalesce from hijacking unrelated header() replace args after POST ?? assignments. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Maintainer verification (2026-06-21):
Compiler call-arg lowering fix looks good; merging on repro + bootstrap link. |
This was referenced Jun 21, 2026
PurHur
added a commit
that referenced
this pull request
Jun 21, 2026
…-guard Fix MiniWebApp POST contact empty name after static guard (#10389 follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply-patches.sh --verify-onlyand use it fromci_ensure_vendor_patchessophpc serve/ web smoke no longer pay ~17s vendor patch apply on everyphp-local.shinvocation.examples-web-smoke.shserve readiness wait to 25s as headroom on cold trees.??must not supply theheader(..., true, 303)replace slot when the CFG arg is unrelated (005-SessionsWeb POST redirect).Test plan
./script/php-local.sh vendor/bin/phpunit test/unit/ApplyPatchesTest.php./script/php-local.sh vendor/bin/phpunit test/compliance/JITTest.php --filter header_after_post_coalesce./script/examples-web-smoke.sh(001–007, 009 pass; 003 contact POST name still empty — pre-existing PATH_INFO POST parsing issue, tracked separately)./script/release-readiness.sh --full --json(blocked on 003-MiniWebApp contact needle until POST/name issue is fixed)Made with Cursor