docs: require pull requests for every change to main - #19
Merged
Conversation
main now enforces branch protection for admins too, so a direct push is rejected. Record the rule and the merge conditions where agents and contributors already look for workflow constraints.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded mandatory workflow rules for ChangesPull Request Workflow Rules
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No issue — this documents a repository setting change made directly on GitHub.
Problem
mainhad branch protection, butenforce_adminswas off and required approvals were0. Adminsbypassed every rule, so changes were landing on
mainby direct push with no PR and no gate. Theconstraint existed on paper but not in practice.
What changed
mainbranch protection now setsenforce_admins: true. Direct pushes are rejected for everyone,admins included — verified by an empty commit that came back
GH006: Changes must be made through a pull request.Required approvals stay at
0deliberately: the repository has a single collaborator, andcoderabbitaionly ever submitsCOMMENTEDreviews, neverAPPROVED. Requiring an approval wouldmake every self-authored PR permanently unmergeable. The gate is therefore PR + green checks +
resolved conversations rather than a human approval signature.
This PR records the rule in
AGENTS.md, where the other workflow constraints live, and is itselfthe first change to go through the new flow.
Checklist
gen-changesetsskill, or this PR needs no changeset. — docs-only, no CLI bumpgen-docsskill, or this PR needs no doc update.Summary by CodeRabbit