[BACKPORT] Fix bert performance regressions on release branch#2331
Merged
Conversation
… bitcasts to reduce excessive codegen
* Fix barrier placement for scheduleVersion = 1. It should appear before LDSRead and not before GlobalLoad.
…gs for attention (#2237) Full cherry-pick of 8b45d8a from develop. * RockPipeline: replace pair-only swap with topological sort (Kahn's algorithm) to handle chained private-memory RAW dependencies (e.g. three-way stage rotations) * BlockwiseGemmToThreadwise: fix rthreads calculation to avoid LDS aliasing when rthreads does not evenly divide rDimSize * Add LIT test for rthreads fix in lowering_blockwise_broadcast_reduce * Add LIT test for three-way swap in test_rock_pipeline * Add E2E attention tests for gfx90a and gfx950 Made-with: Cursor
justinrosner
approved these changes
Apr 6, 2026
stefankoncarevic
approved these changes
Apr 6, 2026
Member
Author
Contributor
|
Cherry pick PR created: ROCm/AMDMIGraphX#4756 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick some fixes to fix performance on bert models
More details at ticket SWDEV-580287
This cherry pick brings back the performance and does a little better compared to QA's baseline