Optimize ros1#325
Merged
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
I've also generated an equivalent C++ benchmark and run it on the same system the above benchmarking was done on. I've done my best to make the benchmarks as equivalent as possible: I have strong confidence that our ROS1 implementation (at least on the case of large image messages) is now as fast, or FASTER than noetic roscpp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This may have some performance penalties on topics which have frequent small messages and infrequent large messages, but I'm not really sure we'll see a real-world case of that.
Fixes
Closes:
numberChecklist