Skip to content

[Refactor] Fix log typos, redundant annotations, and knip config#7474

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
refactor-cleanup-kit-knip-14000924973228479986
Draft

[Refactor] Fix log typos, redundant annotations, and knip config#7474
gonzaloriestra wants to merge 1 commit intomainfrom
refactor-cleanup-kit-knip-14000924973228479986

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

This PR cleans up several minor issues in the codebase to improve maintainability and remove noise.

WHAT is this pull request doing?

  • Fixes a redundant "file file" typo in debug log messages in packages/cli-kit/src/public/node/fs.ts.
  • Removes an unnecessary @ts-ignore in packages/cli-kit/src/public/node/path.ts.
  • Removes unused @graphql-typed-document-node/core entries from Knip's ignoreDependencies in the root package.json.

How to test your changes?

Run the following commands to ensure everything is still working correctly:
pnpm knip
pnpm --filter @shopify/cli-kit vitest run src/public/node/path.test.ts src/public/node/fs.test.ts
pnpm nx lint cli-kit

Duplicate check

I ran git log --grep="Refactor" and git log --grep="knip" to check for previous similar PRs.

  • b79412428 [Refactor] Remove redundant Knip ignoreDependencies entries: This PR targeted different entries in the past; these new ones were recently flagged by Knip hints.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is NOT user-facing.

PR created automatically by Jules for task 14000924973228479986 started by @gonzaloriestra

- Fix "file file" typo in fs.ts log messages
- Remove unnecessary @ts-ignore in path.ts
- Remove unused Knip ignoreDependencies in package.json
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant