[Refactor] Fix log typos, redundant annotations, and knip config#7474
[Refactor] Fix log typos, redundant annotations, and knip config#7474gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
- Fix "file file" typo in fs.ts log messages - Remove unnecessary @ts-ignore in path.ts - Remove unused Knip ignoreDependencies in package.json
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
This PR cleans up several minor issues in the codebase to improve maintainability and remove noise.
WHAT is this pull request doing?
packages/cli-kit/src/public/node/fs.ts.@ts-ignoreinpackages/cli-kit/src/public/node/path.ts.@graphql-typed-document-node/coreentries from Knip'signoreDependenciesin the rootpackage.json.How to test your changes?
Run the following commands to ensure everything is still working correctly:
pnpm knippnpm --filter @shopify/cli-kit vitest run src/public/node/path.test.ts src/public/node/fs.test.tspnpm nx lint cli-kitDuplicate check
I ran
git log --grep="Refactor"andgit log --grep="knip"to check for previous similar PRs.b79412428 [Refactor] Remove redundant Knip ignoreDependencies entries: This PR targeted different entries in the past; these new ones were recently flagged by Knip hints.Checklist
PR created automatically by Jules for task 14000924973228479986 started by @gonzaloriestra