Skip to content

[Refactor] Fix log typos and redundant annotations #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −4
Open

[Refactor] Fix log typos and redundant annotations #7474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli-kit/src/public/node/fs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function isDirectorySync(path: string): boolean {
* @returns The size of the file in bytes.
*/
export async function fileSize(path: string): Promise<number> {
outputDebug(outputContent`Getting the size of file file at ${outputToken.path(path)}...`)
outputDebug(outputContent`Getting the size of file at ${outputToken.path(path)}...`)
return (await fsStat(path)).size
}

Expand All @@ -380,7 +380,7 @@ export async function fileSize(path: string): Promise<number> {
* @returns The size of the file in bytes.
*/
export function fileSizeSync(path: string): number {
outputDebug(outputContent`Sync-getting the size of file file at ${outputToken.path(path)}...`)
outputDebug(outputContent`Sync-getting the size of file at ${outputToken.path(path)}...`)
return fsStatSync(path).size
}

Expand Down
2 changes: 0 additions & 2 deletions packages/cli-kit/src/public/node/path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ export function commonParentDirectory(first: string, second: string): string {
export function relativizePath(path: string, dir: string = cwd()): string {
const result = commonParentDirectory(path, dir)
const relativePath = relative(dir, path)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
const relativeComponents = relativePath.split('/').filter((component) => component === '..').length
if (result === '/' || relativePath === '' || relativeComponents > 2) {
return path
Expand Down
Loading