Archive REVIEW_FU-P12-T1-3_multi_client_widgets_v2 report#87
Merged
Conversation
Move post-fix review for FU-P12-T1-3 to _Historical/ and register it in ARCHIVE/INDEX.md.
…or broker clients
…r clients - Add _get_peer_uid() using getpeereid() (macOS) / SO_PEERCRED (Linux) - Set socket file to 0600 permissions in UnixSocketServer.start() - Reject connections from different-UID peers with JSON-RPC -32003 - Store verified peer UID on ClientSession.peer_uid - Add 5 new tests: same-UID accept, different-UID reject, UID stored, OSError fail-closed, socket 0600 permissions - Update docs/broker-mode.md with Security boundary section
…for broker clients (PASS)
…ort bind/start fails
…t bind/start fails
…t bind/start fails - Restructure BrokerDaemon.start() with try/except around all post-launch steps - Add _rollback_startup() to cancel read task, terminate upstream, clean files - Move state=READY assignment to after all startup steps succeed - Add TestStartupRollback class (6 tests) covering all rollback scenarios - Add troubleshooting doc for broker bind error and automatic rollback behaviour https://claude.ai/code/session_01GMFnmxsDeKCTWf9Zk7S9Hg
Verdict: Approve Low: _stopped_event/_stop_event not set after rollback (non-reachable paths) Low: upstream stdin not closed in _rollback_startup (harmless in context) Nit: rollback log message lacks exception context https://claude.ai/code/session_01GMFnmxsDeKCTWf9Zk7S9Hg
…rtup event consistency Low-priority follow-up: set _stopped_event and _stop_event in _rollback_startup() to make STOPPED state contract complete for future callers. https://claude.ai/code/session_01GMFnmxsDeKCTWf9Zk7S9Hg
- Add broker bind-error section to DocC Troubleshooting.md (mirrors docs/troubleshooting.md) - Reformat tests/unit/test_broker_daemon.py (ruff format) https://claude.ai/code/session_01GMFnmxsDeKCTWf9Zk7S9Hg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FU-P13-T12 — Enforce local Unix-socket security boundary for broker clients
FU-P13-T13 — Make broker startup transactional when transport bind/start fails
Both have full SELECT → PLAN → EXECUTE → ARCHIVE → REVIEW → FOLLOW-UP → ARCHIVE-REVIEW cycles committed and pushed.