Fix uW, ca53, bp_single and bp_dual metric failures#4357
Conversation
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
| Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -474000.0 | -389000.0 | Tighten | | cts__timing__hold__tns | -4700.0 | -763.0 | Tighten | | globalroute__timing__setup__tns | -79400.0 | -48500.0 | Tighten | | globalroute__timing__hold__ws | -275.0 | -375.0 | Failing | | finish__timing__setup__tns | -1430.0 | -1850.0 | Failing | Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
| Metric | Old | New | Type | | ------ | --- | --- | ---- | | finish__timing__hold__tns | -4350.0 | -5290.0 | Failing | Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
| Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -614.0 | -750.0 | Failing | | cts__timing__setup__tns | -1500000.0 | -1670000.0 | Failing | | globalroute__timing__setup__ws | -201.0 | -117.0 | Tighten | | globalroute__timing__setup__tns | -6470.0 | -541.0 | Tighten | | finish__timing__setup__tns | -1160.0 | -989.0 | Tighten | Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD submodule and adjusts the regression baseline rules for several gf12 designs (bp_dual, bp_single, and ca53). The reviewer highlighted multiple significant timing degradations in setup and hold times across different stages (CTS, global routing, and finishing). Before merging, these regressions require either an explicit agreement or the creation of tracking issues to address the underlying performance drops.
| }, | ||
| "finish__timing__hold__tns": { | ||
| "value": -4350.0, | ||
| "value": -5290.0, |
There was a problem hiding this comment.
This timing baseline shows a significant degradation from -4350.0 to -5290.0 (~21.6%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.
References
- It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.
| }, | ||
| "finish__timing__setup__tns": { | ||
| "value": -1430.0, | ||
| "value": -1850.0, |
There was a problem hiding this comment.
This timing baseline shows a significant degradation from -1430.0 to -1850.0 (~29.3%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.
References
- It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.
| }, | ||
| "globalroute__timing__hold__ws": { | ||
| "value": -275.0, | ||
| "value": -375.0, |
There was a problem hiding this comment.
This timing baseline shows a significant degradation from -275.0 to -375.0 (~36.4%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.
References
- It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.
| }, | ||
| "cts__timing__setup__tns": { | ||
| "value": -1500000.0, | ||
| "value": -1670000.0, |
There was a problem hiding this comment.
This timing baseline shows a significant degradation from -1500000.0 to -1670000.0 (~11.3%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.
References
- It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.
| }, | ||
| "cts__timing__setup__ws": { | ||
| "value": -614.0, | ||
| "value": -750.0, |
There was a problem hiding this comment.
This timing baseline shows a significant degradation from -614.0 to -750.0 (~22.1%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.
References
- It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Fix metric failuers after PR https://github.com/The-OpenROAD-Project-private/OpenROAD/pull/3573.
Bump Or version for master failure.
designs/gf12/bp_single/rules-base.json updates:
designs/gf12/ca53/rules-base.json updates:
designs/gf12/bp_dual/rules-base.json updates: