Skip to content

Fix uW, ca53, bp_single and bp_dual metric failures#4357

Open
arthurjolo wants to merge 5 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:fix_ci_failures
Open

Fix uW, ca53, bp_single and bp_dual metric failures#4357
arthurjolo wants to merge 5 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:fix_ci_failures

Conversation

@arthurjolo

Copy link
Copy Markdown
Contributor

Fix metric failuers after PR https://github.com/The-OpenROAD-Project-private/OpenROAD/pull/3573.
Bump Or version for master failure.

designs/gf12/bp_single/rules-base.json updates:

Metric Old New Type
cts__timing__setup__tns -474000.0 -389000.0 Tighten
cts__timing__hold__tns -4700.0 -763.0 Tighten
globalroute__timing__setup__tns -79400.0 -48500.0 Tighten
globalroute__timing__hold__ws -275.0 -375.0 Failing
finish__timing__setup__tns -1430.0 -1850.0 Failing

designs/gf12/ca53/rules-base.json updates:

Metric Old New Type
finish__timing__hold__tns -4350.0 -5290.0 Failing

designs/gf12/bp_dual/rules-base.json updates:

Metric Old New Type
cts__timing__setup__ws -614.0 -750.0 Failing
cts__timing__setup__tns -1500000.0 -1670000.0 Failing
globalroute__timing__setup__ws -201.0 -117.0 Tighten
globalroute__timing__setup__tns -6470.0 -541.0 Tighten
finish__timing__setup__tns -1160.0 -989.0 Tighten

Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__tns                       |  -474000.0 |  -389000.0 | Tighten  |
| cts__timing__hold__tns                        |    -4700.0 |     -763.0 | Tighten  |
| globalroute__timing__setup__tns               |   -79400.0 |   -48500.0 | Tighten  |
| globalroute__timing__hold__ws                 |     -275.0 |     -375.0 | Failing  |
| finish__timing__setup__tns                    |    -1430.0 |    -1850.0 | Failing  |

Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| finish__timing__hold__tns                     |    -4350.0 |    -5290.0 | Failing  |

Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__ws                        |     -614.0 |     -750.0 | Failing  |
| cts__timing__setup__tns                       | -1500000.0 | -1670000.0 | Failing  |
| globalroute__timing__setup__ws                |     -201.0 |     -117.0 | Tighten  |
| globalroute__timing__setup__tns               |    -6470.0 |     -541.0 | Tighten  |
| finish__timing__setup__tns                    |    -1160.0 |     -989.0 | Tighten  |

Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
@arthurjolo arthurjolo self-assigned this Jul 14, 2026
@arthurjolo
arthurjolo requested a review from maliberty July 14, 2026 19:58

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenROAD submodule and adjusts the regression baseline rules for several gf12 designs (bp_dual, bp_single, and ca53). The reviewer highlighted multiple significant timing degradations in setup and hold times across different stages (CTS, global routing, and finishing). Before merging, these regressions require either an explicit agreement or the creation of tracking issues to address the underlying performance drops.

},
"finish__timing__hold__tns": {
"value": -4350.0,
"value": -5290.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This timing baseline shows a significant degradation from -4350.0 to -5290.0 (~21.6%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

},
"finish__timing__setup__tns": {
"value": -1430.0,
"value": -1850.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This timing baseline shows a significant degradation from -1430.0 to -1850.0 (~29.3%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

},
"globalroute__timing__hold__ws": {
"value": -275.0,
"value": -375.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This timing baseline shows a significant degradation from -275.0 to -375.0 (~36.4%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

},
"cts__timing__setup__tns": {
"value": -1500000.0,
"value": -1670000.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This timing baseline shows a significant degradation from -1500000.0 to -1670000.0 (~11.3%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

},
"cts__timing__setup__ws": {
"value": -614.0,
"value": -750.0,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This timing baseline shows a significant degradation from -614.0 to -750.0 (~22.1%). Per the general rules, merging updates to regression baselines with significant degradation requires an explicit agreement or tracking issue to address the underlying issue later. A tracking issue or explicit agreement needs to be established and referenced before merging.

References
  1. It is acceptable to merge updates to regression baselines that show significant degradation, provided there is an explicit agreement to address the underlying issue later.

@maliberty
maliberty enabled auto-merge July 14, 2026 20:52
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants