Stspin Motor driver integration#3734
Open
GrayHoang wants to merge 19 commits into
Open
Conversation
GrayHoang
requested review from
Andrewyx,
sauravbanna and
williamckha
as code owners
…are into motor_driver_integration
…or_driver_integration
Contributor
StarrryNight
left a comment
StarrryNight
left a comment
There was a problem hiding this comment.
Reviewed a bit, will finish the rest later
|
|
||
| bool Gpio::pollValue(GpioState state, std::chrono::milliseconds timeout_ms) | ||
| { | ||
| const auto start_time = std::chrono::system_clock::now(); |
Contributor
There was a problem hiding this comment.
``std::chrono::steady_clock::now()` might be the better choice here since it ensures time to monotonically increase
| * motor fault | ||
| * @param motor_faults a set of faults associated with this motor | ||
| */ | ||
| MotorFaultIndicator(bool drive_enabled, |
Contributor
There was a problem hiding this comment.
Passing in drive_enabled seems redundant as we can just initialize the boolean as false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Isolates the motor driver related changes from #3715
resolves #3711
Please look mainly at motor.cpp and the new motor_controller directory in embedded
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue