fix(ui5-table): ignore 1px scrollWidth/clientWidth diff to prevent stuck popin on Safari#13791
Open
aborjinik wants to merge 1 commit into
Open
fix(ui5-table): ignore 1px scrollWidth/clientWidth diff to prevent stuck popin on Safari#13791aborjinik wants to merge 1 commit into
aborjinik wants to merge 1 commit into
Conversation
…uck popin on Safari Safari can report scrollWidth 1px greater than clientWidth during zoom transitions due to subpixel rounding. The previous strict `scrollWidth > clientWidth` check treated this as real overflow and triggered spurious popin cycles that corrupted `_containerWidth`, leaving columns stuck in the popin area even after zooming back out. Treat differences of 1px as no overflow. Real overflows (>= 2px) still trigger popin as before. Fixes: #12812
|
🚀 Deployed on https://pr-13791--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari can report scrollWidth 1px greater than clientWidth during zoom transitions due to subpixel rounding. The previous strict
scrollWidth > clientWidthcheck treated this as real overflow and triggered spurious popin cycles that corrupted_containerWidth, leaving columns stuck in the popin area even after zooming back out.Treat differences of 1px as no overflow. Real overflows (>= 2px) still trigger popin as before.
Fixes: #12812