Skip to content

fix(ui5-table): ignore 1px scrollWidth/clientWidth diff to prevent stuck popin on Safari #13791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aborjinik wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix(ui5-table): ignore 1px scrollWidth/clientWidth diff to prevent stuck popin on Safari #13791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/main/src/Table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,10 +523,12 @@ class Table extends UI5Element {

_onResize() {
const { clientWidth, scrollWidth } = this._tableElement;
// Safari can report scrollWidth 1px greater than clientWidth during zoom transitions
// due to subpixel rounding, so a strict > check triggers spurious popin cycles.
const overflow = scrollWidth - clientWidth;

if (scrollWidth > clientWidth) {
if (overflow > 1) {
// Overflow Handling: Move columns into the popin until overflow is resolved
const overflow = scrollWidth - clientWidth;
const headers = this._getPopinOrderedColumns(false);
const poppedInWidth = headers.reduce((totalPoppedInWidth, headerCell) => {
if (totalPoppedInWidth < overflow && !headerCell._popin) {
Expand Down
Loading