Update common-packages-list.ps1#200
Open
AndrewEhlo wants to merge 2 commits into
Open
Conversation
Update a script to add a dependentmodule to the list if it is not listed in the 'commerce' module list
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ff10c67. Configure here.
| elseif ($packages["$key"] -match "") { | ||
| Write-Warning "The module $key was not found in the commerceModules list. Adding it to the packages list." | ||
| $packages["$key"] = "$($key)_$($dependencyList["$key"]).zip" | ||
| } |
There was a problem hiding this comment.
Missing packageSources on new branch
Low Severity
The new elseif adds a dependency to $packages but never sets $packageSources, unlike the following else block. For keys not already in $packages, -match "" matches the missing entry, so this branch runs instead of else and modules show source unknown in the resolution summary.
Reviewed by Cursor Bugbot for commit ff10c67. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update a script to add a dependentmodule to the list if it is not listed in the 'commerce' module list
Note
Low Risk
Small change to CI/docker package resolution only; affects which module zips get included when a dependency is outside the commerce group, with no auth or production runtime impact.
Overview
First-level dependency resolution in
common-packages-list.ps1now has an extra branch when a custom module’s dependency is not already present in the pre-built$packagesmap (modules seeded from the commerce group and fixed script entries).If that case is hit, the script logs a warning that the module was missing from the commerce module list and adds
ModuleId_requiredVersion.zipusing the version from the custom module’s manifest, instead of only flowing through the existingelsepath that also setspackageSourcestodep:$customModuleId.Reviewed by Cursor Bugbot for commit ff10c67. Bugbot is set up for automated code reviews on this repo. Configure here.