Skip to content

Update common-packages-list.ps1 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndrewEhlo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update common-packages-list.ps1 #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad5bc7
Update common-packages-list.ps1
AndrewEhlo Jun 10, 2025
ff10c67
Merge branch 'master' into VCST-2469-not-in-commerce-list
AndrewEhlo May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docker-env/scripts/common-packages-list.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,10 @@ foreach ($key in $dependencyList.Keys) {
Write-Warning "Unable to parse version from packages list. Tried '$($packages[$key])' -match '\w._(.*).zip'"
}
}
elseif ($packages["$key"] -match "") {
Write-Warning "The module $key was not found in the commerceModules list. Adding it to the packages list."
$packages["$key"] = "$($key)_$($dependencyList["$key"]).zip"
}
Copy link
Copy Markdown

@cursor cursor Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing packageSources on new branch

Low Severity

The new elseif adds a dependency to $packages but never sets $packageSources, unlike the following else block. For keys not already in $packages, -match "" matches the missing entry, so this branch runs instead of else and modules show source unknown in the resolution summary.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ff10c67. Configure here.

else {
$packages["$key"] = "$($key)_$($dependencyList[$key]).zip"
if (-not $packageSources.ContainsKey($key)) { $packageSources["$key"] = "dep:$customModuleId" }
Expand Down