Remove unused variables. NFC - #8972
Merged
Merged
Conversation
These were preventing the latest version of llvm from building binaryen. I guess the unused variable checker got better.
Member
Author
Don't we expect clang to report these unused locals? We do build with |
sbc100
enabled auto-merge (squash)
August 5, 2026 18:11
Member
|
Yeah, I'm not complaining, this is expected as clang gets better at detecting this. I'm not sure why it detects some but not all. |
Member
|
Now if clang can also get to Go's compile time speed... that would be nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were preventing the latest version of llvm from building binaryen.
This was triggered by llvm/llvm-project#203084
See https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8674381472972128657/+/u/Build_Binaryen/stdout