Skip to content

Tests: Move test_http_response_code_constants to getStatusHeaderDesc.php#12305

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65527-move-status-header-desc-test
Open

Tests: Move test_http_response_code_constants to getStatusHeaderDesc.php#12305
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65527-move-status-header-desc-test

Conversation

@itzmekhokan

Copy link
Copy Markdown

Moves test_http_response_code_constants() from the HTTP API test file into the test class for get_status_header_desc(), so all tests for that function live in one place.

What the problem was:

  • test_http_response_code_constants() exercises get_status_header_desc() but was located in tests/phpunit/tests/http/http.php (Tests_HTTP_HTTP).

What the fix does:

  • Moves the test method into Tests_Functions_GetStatusHeaderDesc (tests/phpunit/tests/functions/getStatusHeaderDesc.php).
  • Drops the redundant method-level @Covers ::get_status_header_desc, as the class-level docblock already declares it.

Approach and why:

  • Test body is unchanged; this only relocates it to the canonical file for the function under test, improving discoverability and grouping.

Trac ticket: https://core.trac.wordpress.org/ticket/65527

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.8
Used for: Ticket analysis and tests. All changes were reviewed, validated against the codebase, and are taken responsibility for by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…php.

The test_http_response_code_constants() test exercises get_status_header_desc()
but lived in the HTTP API test file. Move it alongside the other tests for
that function so all tests for get_status_header_desc() are in one place.

The class-level @Covers ::get_status_header_desc annotation on
Tests_Functions_GetStatusHeaderDesc already covers the moved method, so the
redundant method-level @Covers tag is dropped.

Fixes #65527.
@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant