Skip to content

Tests: Move test_http_response_code_constants to getStatusHeaderDesc.php #12305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itzmekhokan wants to merge 1 commit into
base: trunk
Choose a base branch
from
+15 −17
Open

Tests: Move test_http_response_code_constants to getStatusHeaderDesc.php #12305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/phpunit/tests/functions/getStatusHeaderDesc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,19 @@ public function data_get_status_header_desc() {
array( 'random', '' ),
);
}

/**
* @ticket 35426
*/
public function test_http_response_code_constants() {
global $wp_header_to_desc;

$ref = new ReflectionClass( 'WP_Http' );
$constants = $ref->getConstants();

// This primes the `$wp_header_to_desc` global:
get_status_header_desc( 200 );

$this->assertSame( array_keys( $wp_header_to_desc ), array_values( $constants ) );
}
}
17 changes: 0 additions & 17 deletions tests/phpunit/tests/http/http.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,23 +277,6 @@ public function data_wp_parse_url_with_component() {
);
}

/**
* @ticket 35426
*
* @covers ::get_status_header_desc
*/
public function test_http_response_code_constants() {
global $wp_header_to_desc;

$ref = new ReflectionClass( 'WP_Http' );
$constants = $ref->getConstants();

// This primes the `$wp_header_to_desc` global:
get_status_header_desc( 200 );

$this->assertSame( array_keys( $wp_header_to_desc ), array_values( $constants ) );
}

/**
* @ticket 37768
*
Expand Down
Loading