Skip to content

UI: Use link styling for Dag tags#66750

Merged
choo121600 merged 3 commits into
apache:mainfrom
parkhojeong:fix/ui-dag-tag-link-style
May 13, 2026
Merged

UI: Use link styling for Dag tags#66750
choo121600 merged 3 commits into
apache:mainfrom
parkhojeong:fix/ui-dag-tag-link-style

Conversation

@parkhojeong
Copy link
Copy Markdown
Contributor

@parkhojeong parkhojeong commented May 12, 2026

Why

Dag tag links are currently rendered as plain text, making their clickable behavior less obvious

image

Fix

Using Chakra Link with styling helps users more easily recognize each tag as clickable.
Application scope: Dags list and Dag details header

  • Light mode
Screen.Recording.2026-05-12.at.21.07.42.mp4
  • Dark mode
Screen.Recording.2026-05-12.at.21.12.06.mp4

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 12, 2026
@parkhojeong parkhojeong marked this pull request as ready for review May 12, 2026 04:02
Copy link
Copy Markdown
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the tags currently don’t read as clearly clickable.

One suggestion: rather than using an inline-style-based custom background approach that partially bypasses the Chakra styling system, would it make sense to reuse the existing text-link pattern already used in DagsList.tsx for the DagId links?
(Since tags are secondary metadata, we could omit fontWeight="bold".)

<Link asChild color="fg.info">
  <RouterLink to={...}>{...}</RouterLink>
</Link>
Image

@parkhojeong parkhojeong changed the title UI: Add light background to Dag tag link UI: Use link styling for Dag tags May 12, 2026
@parkhojeong
Copy link
Copy Markdown
Contributor Author

parkhojeong commented May 12, 2026

@choo121600

Thanks for the suggestion. It makes sense. Addressed in 46faf67
The PR title and description were also updated

Screen.Recording.2026-05-12.at.21.07.42.mp4

@parkhojeong
Copy link
Copy Markdown
Contributor Author

The failing CI job appears unrelated to this PR. It failed while logging in to ghcr.io during the CI image build

@bbovenzi bbovenzi added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label May 12, 2026
@bbovenzi bbovenzi added this to the Airflow 3.2.2 milestone May 12, 2026
@bbovenzi
Copy link
Copy Markdown
Contributor

In a follow up PR, we should just make a custom RouterLink component to remove all the repeated

<Link asChild color="fg.info"><RouterLink /></Link> code

@parkhojeong
Copy link
Copy Markdown
Contributor Author

In a follow up PR, we should just make a custom RouterLink component to remove all the repeated

<Link asChild color="fg.info"><RouterLink /></Link> code

Good idea. I'll open a follow-up PR for that.

@parkhojeong parkhojeong requested a review from choo121600 May 13, 2026 08:18
@choo121600 choo121600 added the ready for maintainer review Set after triaging when all criteria pass. label May 13, 2026
@choo121600 choo121600 merged commit 43cd2b8 into apache:main May 13, 2026
82 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 13, 2026
* UI: Add light background to Dag tag link

* UI: Use Chakra Link instead of inline style for Dag tags

---------
(cherry picked from commit 43cd2b8)

Co-authored-by: hojeong park <parkhj062@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 13, 2026
* UI: Add light background to Dag tag link

* UI: Use Chakra Link instead of inline style for Dag tags

---------
(cherry picked from commit 43cd2b8)

Co-authored-by: hojeong park <parkhj062@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
bbovenzi pushed a commit that referenced this pull request May 13, 2026
* UI: Add light background to Dag tag link

* UI: Use Chakra Link instead of inline style for Dag tags

---------
(cherry picked from commit 43cd2b8)

Co-authored-by: hojeong park <parkhj062@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
vatsrahul1001 added a commit that referenced this pull request May 20, 2026
* UI: Add light background to Dag tag link

* UI: Use Chakra Link instead of inline style for Dag tags

---------
(cherry picked from commit 43cd2b8)

Co-authored-by: hojeong park <parkhj062@gmail.com>
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants