Skip to content

MINOR: [R] Adjust parallel::detectCores if NA to not break --parallel input in CMake #50317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rok wants to merge 12 commits into
base: main
Choose a base branch
from
+1 −1
Open

MINOR: [R] Adjust parallel::detectCores if NA to not break --parallel input in CMake #50317

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ef59f03
gmake parsing issue
rok Jul 1, 2026
4f135a1
Potential fix for pull request finding
rok Jul 1, 2026
ae00aea
review feedback
rok Jul 2, 2026
f217bd2
Fix -j flag earlier
rok Jul 2, 2026
7999054
another attempt
rok Jul 2, 2026
a623cf5
another attempt
rok Jul 2, 2026
ca8919f
unset + env
rok Jul 3, 2026
4c7c074
sanitize and print
rok Jul 3, 2026
cf523e8
fix NA
rok Jul 3, 2026
6aa0fe6
bash sanitize
rok Jul 3, 2026
5a5ea93
minimal fix
rok Jul 3, 2026
8f4ba35
minimal-er fix
rok Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion r/tools/nixlibs.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ build_libarrow <- function(src_dir, dst_dir) {
# Set up make for parallel building
# CRAN policy says not to use more than 2 cores during checks
# If you have more and want to use more, set MAKEFLAGS or NOT_CRAN
ncores <- parallel::detectCores()
ncores <- max(1, parallel::detectCores(), na.rm = TRUE)

@thisisnic thisisnic Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo; should it be min()?

@rok rok Jul 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case parallel::detectCores() returns 2 we'd have max(1, 2, na.rm = TRUE) which would return 2 which would be preferable over min(1, 2, na.rm = TRUE) which would return 1. Or am I misunderstanding something?

if (!not_cran) {
ncores <- min(ncores, 2)
}
Expand Down
Loading