MINOR: [R] Unset MAKEFLAGS for nested libarrow CMake build by rok · Pull Request #50317 · apache/arrow

rok · 2026-07-01T12:46:21Z

Rationale for this change

What changes are included in this PR?

Bash command used is adjusted to prevent this error.

/usr/bin/cmake --build . --target install -- -j 2
gmake: the '-j' option requires a positive integer argument

Are these changes tested?

By CI.

Are there any user-facing changes?

No.

Copilot

Pull request overview

This PR updates the R static Arrow build script to pass the Make/Ninja parallelism flag in a single token (-jN) to avoid cases where the underlying build tool interprets -j as missing its integer argument.

Changes:

Adjusted the cmake --build invocation to use -j${N_JOBS} instead of -j $N_JOBS.

rok · 2026-07-01T12:52:41Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-01T12:54:58Z

Revision: 6d4a25b

Submitted crossbow builds: ursacomputing/crossbow @ actions-a4227cb8da

Task	Status
test-r-wasm

rok · 2026-07-01T13:15:18Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-01T13:17:36Z

Revision: 1d835a6

Submitted crossbow builds: ursacomputing/crossbow @ actions-c381cbcd47

Task	Status
test-r-wasm

rok · 2026-07-01T13:35:28Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-01T13:38:30Z

Revision: ef59f03

Submitted crossbow builds: ursacomputing/crossbow @ actions-52b31fc83d

Task	Status
test-r-wasm

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

rok · 2026-07-01T14:00:06Z

@github-actions crossbow submit test-r-wasm

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

github-actions · 2026-07-01T14:02:25Z

Revision: 4f135a1

Submitted crossbow builds: ursacomputing/crossbow @ actions-ea2f0ed863

Task	Status
test-r-wasm

rok · 2026-07-01T21:39:41Z

@thisisnic this change might solve the other r-wasm issue.

kou · 2026-07-02T02:10:50Z

    ${SOURCE_DIR}

-${CMAKE} --build . --target install -- -j $N_JOBS
+(unset MAKEFLAGS MFLAGS; ${CMAKE} --build . --target install --parallel "${N_JOBS}")


It seems that this

diff --git a/r/inst/build_arrow_static.sh b/r/inst/build_arrow_static.sh index 349531b75f..02bc4a24c7 100755 --- a/r/inst/build_arrow_static.sh +++ b/r/inst/build_arrow_static.sh @@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \ -G "${CMAKE_GENERATOR:-Unix Makefiles}" \ ${SOURCE_DIR} -${CMAKE} --build . --target install -- -j $N_JOBS +${CMAKE} --build . --target install -- -j$N_JOBS if command -v sccache &> /dev/null; then echo "=== sccache stats after the build ==="

or

diff --git a/r/inst/build_arrow_static.sh b/r/inst/build_arrow_static.sh index 349531b75f..0df5240888 100755 --- a/r/inst/build_arrow_static.sh +++ b/r/inst/build_arrow_static.sh @@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \ -G "${CMAKE_GENERATOR:-Unix Makefiles}" \ ${SOURCE_DIR} -${CMAKE} --build . --target install -- -j $N_JOBS +${CMAKE} --build . --target install --parallel $N_JOBS if command -v sccache &> /dev/null; then echo "=== sccache stats after the build ==="

is enough.

So if change that I get:

+ /usr/bin/cmake --build . --target install --parallel 2 gmake: the '-j' option requires a positive integer argument

and this error on crossbow test-r-wasm. Will try other combinations.

Oh, sorry...

Oh no worries. Do you think we shouldn't use unset MAKEFLAGS MFLAGS;? I'm trying things but didn't find anything useful yet.

Could you show env | sort to consider whether we can unset MAKEFLAGS MFLAGS or not?

The issue was MAKEFLAGS=%s\n' -jNA, which was due to ncores <- parallel::detectCores() returning NA in r/tools/nixlibs.R. This should be resolved now.

github-actions · 2026-07-03T11:27:43Z

Revision: ca8919f

Submitted crossbow builds: ursacomputing/crossbow @ actions-c97534ddb8

Task	Status
test-r-wasm

rok · 2026-07-03T12:48:41Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-03T12:51:34Z

Revision: 4c7c074

Submitted crossbow builds: ursacomputing/crossbow @ actions-e09624349a

Task	Status
test-r-wasm

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

rok · 2026-07-03T13:01:12Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-03T13:03:42Z

Revision: 4c7c074

Submitted crossbow builds: ursacomputing/crossbow @ actions-c84a75e285

Task	Status
test-r-wasm

rok · 2026-07-03T13:22:14Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-03T13:24:33Z

Revision: 6aa0fe6

Submitted crossbow builds: ursacomputing/crossbow @ actions-2aad1c3029

Task	Status
test-r-wasm

rok · 2026-07-03T13:46:58Z

@github-actions crossbow submit test-r-wasm

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

github-actions · 2026-07-03T13:49:41Z

Revision: 5a5ea93

Submitted crossbow builds: ursacomputing/crossbow @ actions-80e6f4beca

Task	Status
test-r-wasm

rok · 2026-07-03T15:03:13Z

@github-actions crossbow submit test-r-wasm

github-actions · 2026-07-03T15:05:26Z

Revision: 8f4ba35

Submitted crossbow builds: ursacomputing/crossbow @ actions-dd5e1d7710

Task	Status
test-r-wasm

thisisnic · 2026-07-03T15:47:12Z

  # CRAN policy says not to use more than 2 cores during checks
  # If you have more and want to use more, set MAKEFLAGS or NOT_CRAN
-  ncores <- parallel::detectCores()
+  ncores <- max(1, parallel::detectCores(), na.rm = TRUE)


Is this a typo; should it be min()?

In case parallel::detectCores() returns 2 we'd have max(1, 2, na.rm = TRUE) which would return 2 which would be preferable over min(1, 2, na.rm = TRUE) which would return 1. Or am I misunderstanding something?

Copilot AI review requested due to automatic review settings July 1, 2026 12:46

rok requested review from jonkeane and thisisnic as code owners July 1, 2026 12:46

github-actions Bot added the Component: R label Jul 1, 2026

Copilot started reviewing on behalf of rok July 1, 2026 12:46 View session

github-actions Bot added the awaiting committer review Awaiting committer review label Jul 1, 2026

Copilot AI reviewed Jul 1, 2026

View reviewed changes

rok force-pushed the wasm_parallel_build_flag branch from 6d4a25b to 1d835a6 Compare July 1, 2026 13:15

gmake parsing issue

ef59f03

rok force-pushed the wasm_parallel_build_flag branch from 1d835a6 to ef59f03 Compare July 1, 2026 13:35

Copilot AI review requested due to automatic review settings July 1, 2026 13:35

Copilot started reviewing on behalf of rok July 1, 2026 13:37 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread r/inst/build_arrow_static.sh Outdated

rok mentioned this pull request Jul 1, 2026

GH-50295: [C++][R] #include <ranges> in vector_select_k.cc breaks macOS CRAN and wasm builds #50297

Merged

Potential fix for pull request finding

4f135a1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 1, 2026 13:59

Copilot started reviewing on behalf of rok July 1, 2026 14:00 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

rok changed the title ~~MINOR: [R] Use CMake -j${N_JOBS} instead of -j $N_JOBS~~ MINOR: [R] Unset MAKEFLAGS for nested libarrow CMake build Jul 1, 2026

kou reviewed Jul 2, 2026

View reviewed changes

github-actions Bot removed the awaiting committer review Awaiting committer review label Jul 2, 2026

sanitize and print

4c7c074

Copilot AI review requested due to automatic review settings July 3, 2026 12:47

Copilot started reviewing on behalf of rok July 3, 2026 12:48 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread r/inst/build_arrow_static.sh Outdated

Comment thread r/inst/build_arrow_static.sh Outdated

fix NA

cf523e8

bash sanitize

6aa0fe6

minimal fix

5a5ea93

Copilot AI review requested due to automatic review settings July 3, 2026 13:46

Copilot started reviewing on behalf of rok July 3, 2026 13:47 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread r/inst/build_arrow_static.sh Outdated

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jul 3, 2026

minimal-er fix

8f4ba35

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jul 3, 2026

rok requested a review from kou July 3, 2026 15:17

thisisnic reviewed Jul 3, 2026

View reviewed changes

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jul 3, 2026

Uh oh!

Conversation

rok commented Jul 1, 2026

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

rok commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

rok commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

rok commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rok commented Jul 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

rok commented Jul 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

rok commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

rok commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

rok commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

rok commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!