Update SQLite expression display expectations - #22
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Apache DataFusion PR apache/datafusion#23356 adds precedence-preserving parentheses to nested binary and unary expression display names. The SQLite compatibility tests still expect the previous duplicate-projection error messages.
Changes
Update 30 affected error-message expectations across 25 SQLite test files. The SQL queries and expected query results are unchanged.
Testing
Pointed DataFusion's
datafusion-testingsubmodule at this commit and ran:cargo test --features backtrace,parquet_encryption --profile ci-optimized --test sqllogictests -- --include-sqliteAll 1,098 files completed successfully.