feat: logical plan protobuf representation for range repartitioning#23030
Open
saadtajwar wants to merge 7 commits into
Open
feat: logical plan protobuf representation for range repartitioning#23030saadtajwar wants to merge 7 commits into
saadtajwar wants to merge 7 commits into
Conversation
saadtajwar
commented
Jun 19, 2026
| } | ||
|
|
||
| message RangeRepartition { | ||
| repeated SortExprNode expr = 1; |
Author
There was a problem hiding this comment.
I noticed the physical plan field called this sort_expr, I could change this to match if needed?
saadtajwar
commented
Jun 19, 2026
| Error::General(message.into()) | ||
| } | ||
|
|
||
| pub fn parse_protobuf_range_split_point( |
Author
There was a problem hiding this comment.
Copied this & serialize_range_split_point from the physical plan logic by @gene-bordegaray ! 😁
saadtajwar
commented
Jun 19, 2026
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn roundtrip_range_partitioning() -> Result<()> { |
Author
There was a problem hiding this comment.
Happy to add more tests here if needed!
Merge new MergeInto/DML imports from upstream with range partitioning additions.
Author
|
@gene-bordegaray tagging you in here - please let me know your thoughts! Looking forward to any feedback & working together further on this effort! 😁 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The range repartitioning scheme for logical plans does not currently have a protobuf representation.
What changes are included in this PR?
A protobuf representation of the
RangeRepartitionstruct was added todatafusion.proto, and the codegened Rust types were created. Added logic for serializing and deserializing to and from the protobuf representation, and a roundtrip test as well!Are these changes tested?
Yes! Added a test in
roundtrip_logical_planAre there any user-facing changes?
No, adding internal protobuf serialization support for an existing logical plan variant