-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: logical plan protobuf representation for range repartitioning #23030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saadtajwar
wants to merge
7
commits into
apache:main
Choose a base branch
from
saadtajwar:saadt/logical-protobuf-serialization-range-repartitioning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
39186d0
feat: supporting logical protobuf serialization for range repartitioning
saadtajwar 5e7e9ec
serialization to proto type and used in mod.rs
saadtajwar 66fc007
from proto
saadtajwar 7542d1c
roundtrip test added
saadtajwar d368072
quick lint fixes
saadtajwar 12515b0
lint again
saadtajwar 89afee6
Resolve merge conflicts with upstream/main
saadtajwar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ use std::sync::Arc; | |
| use arrow::datatypes::{DataType, Field}; | ||
| use datafusion_common::datatype::DataTypeExt; | ||
| use datafusion_common::{ | ||
| NullEquality, RecursionUnnestOption, Result, ScalarValue, TableReference, | ||
| NullEquality, RecursionUnnestOption, Result, ScalarValue, SplitPoint, TableReference, | ||
| UnnestOptions, exec_datafusion_err, internal_err, plan_datafusion_err, | ||
| }; | ||
| use datafusion_execution::TaskContext; | ||
|
|
@@ -899,3 +899,14 @@ fn parse_required_expr( | |
| fn proto_error<S: Into<String>>(message: S) -> Error { | ||
| Error::General(message.into()) | ||
| } | ||
|
|
||
| pub fn parse_protobuf_range_split_point( | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copied this & |
||
| split_point: &protobuf::RangeSplitPoint, | ||
| ) -> Result<SplitPoint, Error> { | ||
| let values = split_point | ||
| .value | ||
| .iter() | ||
| .map(ScalarValue::try_from) | ||
| .collect::<Result<_, Error>>()?; | ||
| Ok(SplitPoint::new(values)) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the physical plan field called this
sort_expr, I could change this to match if needed?